sbtc-developer-release icon indicating copy to clipboard operation
sbtc-developer-release copied to clipboard

[sBTC DR] chore: Remove deprecated @types/typescript dependency

Open moodmosaic opened this issue 2 years ago • 3 comments

Summary:

Removed the deprecated @types/typescript dependency from romeo/asset-contract/package.json as TypeScript provides its own type definitions. This addresses the npm warning seen during installation.

Changes:

  • Removed @types/typescript from romeo/asset-contract/package.json.

Benefits:

  • Simplifies the package dependencies.
  • Eliminates the npm warning related to the deprecated package.

Testing

Once you cd into romeo/asset-contract directory, run npm install and there should be no warnings.

Risks

How were these changes tested?

By cding into romeo/asset-contract directory and running npm install and then npm test.

What future testing should occur?

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

(Let me know if there's a style guideline of this project that I can follow, and any changes to the documentation that I should make. There are no dependent changes in downstream modules.)

moodmosaic avatar Nov 02 '23 06:11 moodmosaic

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6470223) 43.44% compared to head (14ef8bf) 43.44%. Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   43.44%   43.44%           
=======================================
  Files          45       45           
  Lines        5467     5467           
  Branches       47       47           
=======================================
  Hits         2375     2375           
  Misses       3091     3091           
  Partials        1        1           
Flag Coverage Δ
unittests 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 02 '23 06:11 codecov[bot]

Gentle ping 🏓 👀

moodmosaic avatar Nov 07 '23 21:11 moodmosaic

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 16 '23 06:11 CLAassistant