stackrox icon indicating copy to clipboard operation
stackrox copied to clipboard

ROX-28296: reencrypt route operator integration

Open stehessel opened this issue 8 months ago • 5 comments

Description

Add the reencrypt route that was introduced in #14416 to the operator CRD.

  • If destinationCACertificate is set it should use this value.
  • If destinationCACertificate is not set, we default to the CA defined in central-tls.
SCR-20250407-jwly

User-facing documentation

  • [x] CHANGELOG is updated OR update is not needed
  • [x] documentation PR is created and is linked above OR is not needed

Testing and quality

  • [x] the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • [x] CI results are inspected

Automated testing

  • [x] added unit tests
  • [ ] added e2e tests
  • [ ] added regression tests
  • [ ] added compatibility tests
  • [ ] modified existing tests

How I validated my change

Installed the operator from catalog source and tested installation with and without custom destination CA.

stehessel avatar Mar 26 '25 16:03 stehessel

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Mar 26 '25 16:03 openshift-ci[bot]

Images are ready for the commit at 6f58aca.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-467-g6f58aca4ed.

rhacs-bot avatar Mar 26 '25 17:03 rhacs-bot

Codecov Report

Attention: Patch coverage is 85.48387% with 9 lines in your changes missing coverage. Please review.

Project coverage is 48.95%. Comparing base (eded5b5) to head (6f58aca). Report is 56 commits behind head on master.

Files with missing lines Patch % Lines
operator/internal/route/translation.go 84.61% 4 Missing and 2 partials :warning:
...internal/central/values/translation/translation.go 86.36% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14771      +/-   ##
==========================================
- Coverage   48.96%   48.95%   -0.02%     
==========================================
  Files        2550     2550              
  Lines      187233   187213      -20     
==========================================
- Hits        91687    91652      -35     
- Misses      88298    88318      +20     
+ Partials     7248     7243       -5     
Flag Coverage Δ
go-unit-tests 48.95% <85.48%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 26 '25 17:03 codecov[bot]

/test all

stehessel avatar Apr 03 '25 14:04 stehessel

/retest

stehessel avatar Apr 15 '25 09:04 stehessel