stackrox icon indicating copy to clipboard operation
stackrox copied to clipboard

ROX-26375: remove ability to rollback to release older than 4.3

Open dashrews78 opened this issue 1 year ago • 2 comments

Description

change me!

User-facing documentation

  • [ ] CHANGELOG is updated OR update is not needed
  • [ ] documentation PR is created and is linked above OR is not needed

Testing and quality

  • [ ] the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • [ ] CI results are inspected

Automated testing

  • [ ] added unit tests
  • [ ] added e2e tests
  • [ ] added regression tests
  • [ ] added compatibility tests
  • [ ] modified existing tests

How I validated my change

Ran CI before changing the upgrade test to verify it failed trying to rollback to 4.1. https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/stackrox_stackrox/12801/pull-ci-stackrox-stackrox-master-gke-upgrade-tests/1838659525264019456

dashrews78 avatar Sep 24 '24 17:09 dashrews78

Images are ready for the commit at c4efd0d.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-637-gc4efd0dcbe.

rhacs-bot avatar Sep 24 '24 18:09 rhacs-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.25%. Comparing base (d20bca1) to head (c4efd0d). Report is 71 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12801      +/-   ##
==========================================
+ Coverage   48.23%   48.25%   +0.01%     
==========================================
  Files        2442     2442              
  Lines      175411   175485      +74     
==========================================
+ Hits        84615    84677      +62     
- Misses      83984    83996      +12     
  Partials     6812     6812              
Flag Coverage Δ
go-unit-tests 48.25% <ø> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 02 '24 19:10 codecov[bot]

@dashrews78: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-upgrade-tests c4efd0dcbeca942ec91a73cfe8008bea7a73c0a7 link false /test gke-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 03 '24 18:10 openshift-ci[bot]