stackrox
stackrox copied to clipboard
ROX-25439: Change template and remove flag options
Description
Removes feature flag functionality from the template and code. This PR requires parts 1-4 to be merged first. This reverts functionality added with #8636 for using feature flags in proto files.
This branch is based on mtodor/ROX-25439-remove-features-part4 - used in PR #12793
User-facing documentation
- [x] CHANGELOG is updated OR update is not needed
- [x] documentation PR is created and is linked above OR is not needed
Testing and quality
- [x] the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
- [ ] CI results are inspected
Automated testing
- [x] didn't change any tests
How I validated my change
I did run make go-generated-srcs - for GENERATE_PATH=central/deployment/datastore/internal/store/postgres/gen.go
Images are ready for the commit at 83cf052.
To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-672-g83cf052494.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 48.20%. Comparing base (
db45ed4) to head (83cf052). Report is 16 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #12794 +/- ##
==========================================
- Coverage 48.20% 48.20% -0.01%
==========================================
Files 2443 2443
Lines 175789 175780 -9
==========================================
- Hits 84737 84730 -7
+ Misses 84226 84225 -1
+ Partials 6826 6825 -1
| Flag | Coverage Δ | |
|---|---|---|
| go-unit-tests | 48.20% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@dashrews78 @stehessel I have adjusted this PR to remove support of "disable sub-tables in proto files by feature flags". Since it is not used, there is no need to keep code for it.
@mtodor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/ocp-4-16-nongroovy-e2e-tests | da0bd8c8156b2513d63136aa059442c933fe413f | link | false | /test ocp-4-16-nongroovy-e2e-tests |
| ci/prow/ocp-4-16-qa-e2e-tests | da0bd8c8156b2513d63136aa059442c933fe413f | link | false | /test ocp-4-16-qa-e2e-tests |
| ci/prow/ocp-4-16-operator-e2e-tests | da0bd8c8156b2513d63136aa059442c933fe413f | link | false | /test ocp-4-16-operator-e2e-tests |
| ci/prow/ocp-4-16-ui-e2e-tests | da0bd8c8156b2513d63136aa059442c933fe413f | link | false | /test ocp-4-16-ui-e2e-tests |
| ci/prow/ocp-4-16-scanner-v4-tests | da0bd8c8156b2513d63136aa059442c933fe413f | link | false | /test ocp-4-16-scanner-v4-tests |
| ci/prow/gke-ui-e2e-tests | da0bd8c8156b2513d63136aa059442c933fe413f | link | false | /test gke-ui-e2e-tests |
| ci/prow/gke-scanner-v4-tests | da0bd8c8156b2513d63136aa059442c933fe413f | link | false | /test gke-scanner-v4-tests |
| ci/prow/ocp-4-12-scanner-v4-tests | da0bd8c8156b2513d63136aa059442c933fe413f | link | false | /test ocp-4-12-scanner-v4-tests |
| ci/prow/ocp-4-12-ui-e2e-tests | da0bd8c8156b2513d63136aa059442c933fe413f | link | false | /test ocp-4-12-ui-e2e-tests |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/test gke-nongroovy-e2e-tests