stackrox icon indicating copy to clipboard operation
stackrox copied to clipboard

ROX-25461: Expose feature flag service on sensor

Open rhybrillou opened this issue 1 year ago • 3 comments

Description

Let sensor expose its feature flags to allow synchronization from central configuration source on secured cluster components.

User-facing documentation

  • [ ] CHANGELOG is updated OR update is not needed
  • [ ] documentation PR is created and is linked above OR is not needed

Testing

  • [ ] inspected CI results

Automated testing

How I validated my change

Deployed local RHACS (central + sensor) Forwarded sensor HTTP port locally Query /v1/featureflags with curl on locally forwarded port and check there is a response.

rhybrillou avatar Jul 26 '24 09:07 rhybrillou

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Jul 26 '24 09:07 openshift-ci[bot]

Images are ready for the commit at eb935ed.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-148-geb935ed15e.

rhacs-bot avatar Jul 26 '24 09:07 rhacs-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.21%. Comparing base (3859a75) to head (5eccf9b).

Additional details and impacted files
@@                           Coverage Diff                            @@
##           yann/extract_feature_flag_svc_to_pkg   #12155      +/-   ##
========================================================================
+ Coverage                                 40.43%   48.21%   +7.77%     
========================================================================
  Files                                      1916     2403     +487     
  Lines                                    140084   171636   +31552     
========================================================================
+ Hits                                      56645    82747   +26102     
- Misses                                    79317    82207    +2890     
- Partials                                   4122     6682    +2560     
Flag Coverage Δ
go-unit-tests 48.21% <ø> (+7.77%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 26 '24 10:07 codecov[bot]

Work deprioritized.

rhybrillou avatar Aug 07 '24 12:08 rhybrillou