fix: run must-gather in e2e post-tests

[tommartensen]

trafficstars

Description

Enabling collection of OpenShift debugging information at the end of e2e tests.

Checklist

• [ ] Investigated and inspected CI test results
• [ ] Unit test and regression tests added
• [ ] Evaluated and added CHANGELOG entry if required
• [ ] Determined and documented upgrade steps
• [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Here I tell how I validated my change

TODO(replace-me)
Use this space to explain how you validated that your change functions exactly how you expect it. Feel free to attach JSON snippets, curl commands, screenshots, etc. Apply a simple benchmark: would the information you provided convince any reviewer or any external reader that you did enough to validate your change.

It is acceptable to assume trust and keep this section light, e.g. as a bullet-point list.

It is acceptable to skip testing in cases when CI is sufficient, or it's a markdown or code comment change only.
It is also acceptable to skip testing for changes that are too taxing to test before merging. In such case you are responsible for the change after it gets merged which includes reverting, fixing, etc. Make sure you validate the change ASAP after it gets merged or explain in PR when the validation will be performed.
Explain here why you skipped testing in case you did so.

Have you created automated tests for your change? Explain here which validation activities you did manually and why so.

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the performed testing and you are satisfied with it.

[gitguardian[bot]]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
10835418	Triggered	Generic CLI Secret	7b43193b187272696190714044627bdcd08a36ed	scripts/ci/lib.sh	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[rhacs-bot]

Images are ready for the commit at 0b6ed6c.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-1055-g0b6ed6c62c.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.04%. Comparing base (5604a0f) to head (0b6ed6c). Report is 2539 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11615      +/-   ##
==========================================
+ Coverage   48.01%   48.04%   +0.02%     
==========================================
  Files        2358     2358              
  Lines      169367   169426      +59     
==========================================
+ Hits        81319    81395      +76     
+ Misses      81527    81504      -23     
- Partials     6521     6527       +6     

Flag	Coverage Δ
go-unit-tests	48.04% <ø> (+0.02%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[openshift-ci[bot]]

@tommartensen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ocp-4-12-nongroovy-e2e-tests	0b6ed6c62c1b2b4e6a9e2187873b6f042c5569fa	link	false	/test ocp-4-12-nongroovy-e2e-tests
ci/prow/ocp-4-12-scanner-v4-tests	0b6ed6c62c1b2b4e6a9e2187873b6f042c5569fa	link	false	/test ocp-4-12-scanner-v4-tests
ci/prow/ocp-4-12-operator-e2e-tests	0b6ed6c62c1b2b4e6a9e2187873b6f042c5569fa	link	false	/test ocp-4-12-operator-e2e-tests
ci/prow/ocp-4-12-qa-e2e-tests	0b6ed6c62c1b2b4e6a9e2187873b6f042c5569fa	link	false	/test ocp-4-12-qa-e2e-tests
ci/prow/gke-ui-e2e-tests	0b6ed6c62c1b2b4e6a9e2187873b6f042c5569fa	link	true	/test gke-ui-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.