scanner
scanner copied to clipboard
stackrox
feat: Use versioned offline defs in offline bundles
Description
Update the offline bundle workflow to use versioned offline definitions (create based on https://github.com/stackrox/stackrox/pull/12516/files) instead of release-based defintions. Also, from 4.6.x onward, versioned offline bundles are published by Z-stream.
Test
In progress, waiting on https://github.com/stackrox/stackrox/pull/12516/files for full end-to-end testing.
Preliminary review:
Could you please send me the full review? I am OK waiting a bit for a full review, in case you're holding the remainder waiting for my replies on this preliminary.
Could you please send me the full review? I am OK waiting a bit for a full review, in case you're holding the remainder waiting for my replies on this preliminary.
Called it preliminary due to not being tested yet:
In progress, waiting on https://github.com/stackrox/stackrox/pull/12516/files for full end-to-end testing.
Should we wait for that PR to be merged and for you to do your testing before reviewing this?
In progress, waiting on https://github.com/stackrox/stackrox/pull/12516/files for full end-to-end testing.
Should we wait for that PR to be merged and for you to do your testing before reviewing this?
I see this was already asked, and it seems like you still want a review, so I'll look
@jvdm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/scale-tests | 92a330e06a44b0de46f32f3c295d71c8f3b05741 | link | false | /test scale-tests |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
The description of this PR says it's still untested. Is that still true?
No, tests were made on dev builds for 4.6.x, see description.