scanner icon indicating copy to clipboard operation
scanner copied to clipboard

chore: Update oci-ta tasks, add Renovate config

Open red-hat-konflux[bot] opened this issue 1 year ago • 6 comments

@msugakov: I took over this PR adding more maintenance things on top of Renovate's change. It's best to review this PR per commit.

Relates to ROX-22359

red-hat-konflux[bot] avatar Jul 22 '24 16:07 red-hat-konflux[bot]

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jul 22 '24 16:07 openshift-ci[bot]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

red-hat-konflux[bot] avatar Jul 22 '24 18:07 red-hat-konflux[bot]

/renovate rebase

msugakov avatar Jul 24 '24 08:07 msugakov

This is going to be fun: there's a behavior change in the task so that it does not seem to allow passing through the chain. DBs failed but scanners did not. Probably because DBs don't do any actual dependency prefetch. I think we should just put blobs fetch before dependencies prefetch to solve the issue.

msugakov avatar Jul 24 '24 09:07 msugakov

/ok-to-test

msugakov avatar Aug 05 '24 09:08 msugakov

/retest

msugakov avatar Aug 05 '24 16:08 msugakov

It seems to me that prefetch tasks puts some skip marker file so that the next attempt to save oci artifact bails out respecting that file.

msugakov avatar Aug 06 '24 09:08 msugakov

The pipeline run where this happened is https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/scanner-db-build-vtkz6

msugakov avatar Aug 06 '24 09:08 msugakov

It seems to me that prefetch tasks puts some skip marker file so that the next attempt to save oci artifact bails out respecting that file.

👍 Could you check that the pipeline run timeout is still accurate?

tommartensen avatar Aug 06 '24 09:08 tommartensen

@red-hat-konflux[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/scale-tests aac7b788176d510d04987665e0c3b46ed5c9cd98 link false /test scale-tests
ci/prow/slim-e2e-tests aac7b788176d510d04987665e0c3b46ed5c9cd98 link false /test slim-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 06 '24 10:08 openshift-ci[bot]

/retest scanner-db-build

msugakov avatar Aug 06 '24 15:08 msugakov

@msugakov: The /retest command does not accept any targets. The following commands are available to trigger optional jobs:

  • /test e2e-tests
  • /test scale-tests
  • /test slim-e2e-tests

Use /test all to run all jobs.

In response to this:

/retest scanner-db-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 06 '24 15:08 openshift-ci[bot]

scanner-db-build even if it timeouts got successfully to the last two tasks. It was just slow due to multiarch and pipelines slowness. I don't want to bump *-db-* timeouts just yet. Will merge.

msugakov avatar Aug 06 '24 15:08 msugakov