collector
collector copied to clipboard
stackrox
Ppc64le multiarch
Hi @sumitd2. Thanks for your PR.
I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
docker buildx buildcannot be simply followed up bydocker pushordocker runetc.; the docker daemon cannot directly accessbuildx buildimages. If you're just building the image to see if it will build on multiple arches, then fine, but if you're planning on pushing or running the images, then you need to adapt those steps accordingly as well. We can use neither buildx build --load (doesnt work with multiarch images), nor --push (we cant push after every build). Looks like this PR is a waste.docker buildxandTARGETPLATFORMhacks are fine for upstream/CI but not for downstream; it doesn't seem like these dockerfiles could or would be used downstream anyway, but just checking. No sure why. AFAIK TARGETPLATFORM is the only way to select a platform specific base image and execute platform specific code.- There are a few files noted below which, once squashed, end up with only cosmetic changes; just remove those entirely. Done
- What about s390x? That will be a separate PR from a different team.
On a strategic level, I think that it would be cleaner to add parameters to the build than to add tests about the architecture as part of the build process. ... In conclusion, I wish we could keep arch/distro specific stuff only inside the code creating CI/CD pipelines, providing as many parameters as required to handle the specifics of each build (like the base image for the builder, for instance).
@sumitd2 , I would love to hear about your opinion on this subject, as it appears that your are pursuing in the exact same direction as before.
@ovalenti Hi Olivier, apologies for the late reply. I am still trying to comprehend your suggestions. I am responsible for porting the code to power, and don't know much about the code or the functionality it implements. I have asked a Redhat team member (@robbycochran) to analyse your post and post a suitable reply. I am taking the same direction in the meanwhile as we are in a bit of a hurry for the first release, I just thought your suggestions could possibly be implemented in the second one. Thank you.
@sumitd2: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/unit-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test unit-tests |
| ci/prow/cos-dev-ebpf-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test cos-dev-ebpf-integration-tests |
| ci/prow/cos-89-lts-ebpf-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test cos-89-lts-ebpf-integration-tests |
| ci/prow/flatcar-stable-ebpf-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test flatcar-stable-ebpf-integration-tests |
| ci/prow/cos-85-lts-kernel-module-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test cos-85-lts-kernel-module-integration-tests |
| ci/prow/ubuntu-pro-1804-lts-kernel-module-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test ubuntu-pro-1804-lts-kernel-module-integration-tests |
| ci/prow/cos-stable-kernel-module-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test cos-stable-kernel-module-integration-tests |
| ci/prow/ubuntu-pro-1804-lts-ebpf-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test ubuntu-pro-1804-lts-ebpf-integration-tests |
| ci/prow/ubuntu-1804-lts-kernel-module-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test ubuntu-1804-lts-kernel-module-integration-tests |
| ci/prow/ubuntu-1804-lts-ebpf-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test ubuntu-1804-lts-ebpf-integration-tests |
| ci/prow/ubuntu-2204-lts-ebpf-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test ubuntu-2204-lts-ebpf-integration-tests |
| ci/prow/sles-15-kernel-module-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test sles-15-kernel-module-integration-tests |
| ci/prow/sles-15-ebpf-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test sles-15-ebpf-integration-tests |
| ci/prow/cos-stable-ebpf-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test cos-stable-ebpf-integration-tests |
| ci/prow/garden-linux-kernel-module-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test garden-linux-kernel-module-integration-tests |
| ci/prow/sles-12-kernel-module-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test sles-12-kernel-module-integration-tests |
| ci/prow/ubuntu-2004-lts-kernel-module-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test ubuntu-2004-lts-kernel-module-integration-tests |
| ci/prow/cos-89-lts-kernel-module-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test cos-89-lts-kernel-module-integration-tests |
| ci/prow/cos-85-lts-ebpf-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test cos-85-lts-ebpf-integration-tests |
| ci/prow/rhel-86-sap-kernel-module-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test rhel-86-sap-kernel-module-integration-tests |
| ci/prow/rhel-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test rhel-integration-tests |
| ci/prow/cos-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test cos-integration-tests |
| ci/prow/sles-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test sles-integration-tests |
| ci/prow/ubuntu-os-pro-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test ubuntu-os-pro-integration-tests |
| ci/prow/fedora-coreos-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test fedora-coreos-integration-tests |
| ci/prow/garden-linux-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test garden-linux-integration-tests |
| ci/prow/ubuntu-os-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test ubuntu-os-integration-tests |
| ci/prow/rhel-sap-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test rhel-sap-integration-tests |
| ci/prow/update-support-packages-from-registry | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test update-support-packages-from-registry |
| ci/prow/benchmarks | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test benchmarks |
| ci/prow/flatcar-integration-tests | e5af03a5780f0a4e3ed42708c59d3b5e4d3f5170 | link | true | /test flatcar-integration-tests |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.