pystac icon indicating copy to clipboard operation
pystac copied to clipboard

Tests and documentation for Datacube extension

Open lossyrob opened this issue 4 years ago • 3 comments

As part of #309 the Datacube extension was implemented (closing #30). There's testing and documentation left to do on this extension that should go in before the 1.0 release.

lossyrob avatar May 03 '21 19:05 lossyrob

Moving this out to 1.3.0 release since I won't have time to work on it for 1.2.0

duckontheweb avatar Aug 23 '21 12:08 duckontheweb

Moving this to the next release.

duckontheweb avatar Jan 18 '22 17:01 duckontheweb

I am in process of adding more unit tests to pystac/extensions/datacube.py, but it occurs to me that Dimension takes a dict in it's constructor, so also should have create and apply, same as in https://github.com/stac-utils/pystac/issues/576 .

I think it might turn into a bit of a refactor of some of the datacube classes, because from_dict here seems awkward being defined in the Abstract Base Class.

Instead, from_dict, create and apply could be implemented by the concrete subclasses. Let me know if any opinions pro or con- I am not experienced using the ABC package.

cc @duckontheweb

guidorice avatar Mar 18 '22 20:03 guidorice