obsidian-spaced-repetition icon indicating copy to clipboard operation
obsidian-spaced-repetition copied to clipboard

Published 20 hours ago • verified publisher icon st3v3nmw

[FIX] Folder ignore sorts all folder starting with string

Open 4Source opened this issue 1 year ago • 2 comments

Fixes #969

Implementation of better comparison Implementation of Unit Test

4Source avatar May 24 '24 23:05 4Source

Not sure why the Test Failed for me tried it multiple times no issues with this. Maybe because Test is running on Ubuntu and i am on windows I will check I can Test this on a Virtual machine.

4Source avatar May 24 '24 23:05 4Source

Finally Test succeed

4Source avatar May 25 '24 14:05 4Source

Actually I think we have the same understanding of sub.

Not that it matters too much, but I think we use different terminology in terms of what is "sub". I guess I think of "sub" to encompass less than the original thing, e.g. "subsection".

Where do you mean is this the case?

If I've understood correctly, then I think you have the opposite meaning. That "root" is a subpath of "root/sub/sub2", but encompasses more.

I am not a native speaker so If you say this fits more than I can change it

As an idea, what do you think of "isEqualOrAncestor" instead?

4Source avatar Jul 10 '24 08:07 4Source