opencode
opencode copied to clipboard
feat(session modal): introduce session bookmarking
Building on https://github.com/sst/opencode/pull/1821
With pins
Pinned sessions only
lol ignore these reviews they're garbage
love the idea of pinning sessions, but a few UX/visual nits:
- i don't love the emojis, can we indicate pins another way?
- that bottom menu is getting a bit crowded; can we just always show with pins at the top, do we need to toggle?
yeah sorry I didn't update after my latest commit, I didn't like the pins either and moved to a dot with success color (but had some troubles with the background when highlighting, showing a black box...)
anywho, it now looks like that
I realize that pinning is actually a miss-use of the term on my part, I was more thinking of a "bookmark" system. I feel it doesn't make sense to push the pins/bookmark at the top of the session list, but rather leave them where they are in the item list. This is why I think the bookmark view is a good addition, to filter and only show our bookmarked sessions. It feels more organized this way rather than constantly pushing things at the top when we mark them.
Example: You make a few research sessions and move on to something else. Then later, you go and bookmark those research sessions because they had insight you will need at some point, but not now. It doesn't make sense to me to push them at the top, they will just be a nuisance. Plus if you have say 10 pins, you will have to scroll to see your working sessions.
Regarding the footer being too crowded, we could maybe change:
n new session->n newP pinned view>P filterand maybe add 2 spaces between shortcuts:n new r rename p pin P filteror 3n new r rename p pin P filter(I like 3 better) we could also use a warning color for the letter shortcut adding some dynamism to the footer?
The highlight issue I mentioned is this
EDIT: fixed!
PS: maybe TAB is a better way of toggling to the filtered view?
Hey @adamdotdevin, here's how the suggestions look like
or