ion icon indicating copy to clipboard operation
ion copied to clipboard

docs(astro-sst): update wrong astro output

Open unrevised6419 opened this issue 1 year ago • 1 comments

The only valid astro output values are 'static' | 'server' | 'hybrid'

image

unrevised6419 avatar Aug 14 '24 14:08 unrevised6419

I had the same issue after following the Astro guide. Check this commit from 2 weeks ago:

https://github.com/sst/ion/commit/4f55966b36f4854f5a256d8c46d2e3e051dab919

@jayair is there an explanation for this change?

The README for astro-sst still says to put output: "server"

jbrown avatar Aug 15 '24 16:08 jbrown

Oh man somebody opened an issue about that change and I put it in. Now I can't find it.

@iamandrewluca can you change this back to "server" then.

jayair avatar Aug 22 '24 19:08 jayair

Actually, let me check with @fwang because this what we do internally:

https://github.com/sst/ion/blob/dev/www/astro.config.mjs#L177

jayair avatar Aug 22 '24 19:08 jayair

@jayair too late, changed to server already ))

unrevised6419 avatar Aug 22 '24 19:08 unrevised6419

Fixed in https://github.com/sst/ion/commit/6e3b26b03a4e9d9432de0ccdc622fb8e81551b95

unrevised6419 avatar Sep 11 '24 17:09 unrevised6419