quicktile icon indicating copy to clipboard operation
quicktile copied to clipboard

command chaining functionality in config

Open harindu95 opened this issue 8 years ago • 11 comments

I wanted to make windows borderless when I tile them. Now you can do command chaining with ','

KP_2 = borderless,bottom KP_5 = WithBorder,center

yay!

harindu95 avatar Sep 16 '17 08:09 harindu95

Coverage Status

Coverage decreased (-0.5%) to 33.307% when pulling c1aeaafaab9c09201dab84394eda0aaa3fc6cd08 on harindu95:master into dac1e1a7297d8ca97b935aaba99e675ec392d233 on ssokolow:master.

coveralls avatar Sep 16 '17 08:09 coveralls

Coverage Status

Coverage decreased (-0.5%) to 33.36% when pulling f4064c3e4af8cd0ecbfccd62f99c6ecb9387b31f on harindu95:master into dac1e1a7297d8ca97b935aaba99e675ec392d233 on ssokolow:master.

coveralls avatar Sep 16 '17 08:09 coveralls

Sorry for taking so long to reply. The last few days have been busy.

I'll try to find time to review this within the next couple of days.

ssokolow avatar Sep 18 '17 14:09 ssokolow

Coverage Status

Coverage decreased (-0.5%) to 33.36% when pulling 8d0d0e925ea0095b5438ffc7322fa25e1e4d27e2 on harindu95:master into dac1e1a7297d8ca97b935aaba99e675ec392d233 on ssokolow:master.

coveralls avatar Sep 25 '17 21:09 coveralls

Coverage Status

Coverage decreased (-0.5%) to 33.36% when pulling 76e97dcf9c768f08f3d29260dcd744dd16407d83 on harindu95:master into dac1e1a7297d8ca97b935aaba99e675ec392d233 on ssokolow:master.

coveralls avatar Sep 25 '17 21:09 coveralls

That said, next time I revise the docs, I'll probably also want to add a note that space-separated command-chaining on the command-line is deprecated and may be removed some day in the distant future.

ssokolow avatar Sep 29 '17 16:09 ssokolow

Sorry for remaining silent after your changes.

It's been a very messy week. I'll try to do a final check and then get this merged within the next few days.

ssokolow avatar Oct 29 '17 22:10 ssokolow

Travis-CI is dying with the current version of your pull request with IndentationError: unexpected unindent. That's a flat-out parser error. (ie. It indicates that you didn't even try to run the code you submitted.)

Given how long this has already taken, if I can find the time within the next week, I'll just clean it up myself.

ssokolow avatar Nov 01 '17 20:11 ssokolow

Sorry for the lack of progress. I haven't forgotten about you. I just have some deadlines looming on other projects.

ssokolow avatar Nov 14 '17 06:11 ssokolow

Coverage Status

Coverage decreased (-0.5%) to 33.36% when pulling 418185a1748434fd822cabc10791797f9d34b9f3 on harindu95:master into dac1e1a7297d8ca97b935aaba99e675ec392d233 on ssokolow:master.

coveralls avatar Dec 21 '17 23:12 coveralls

Sorry for being so clumsy. I am still a newbie so forgive me :) . I think I cleaned up the code and the type annotations and it totally works on my machine at least.

harindu95 avatar Dec 21 '17 23:12 harindu95