Pymem icon indicating copy to clipboard operation
Pymem copied to clipboard

Use poetry for dependency management

Open StarrFox opened this issue 3 years ago • 2 comments

closes https://github.com/srounet/Pymem/issues/91

This pull request switches to a pyproject.toml file which uses poetry, it also attempts to adapt the appveyor to use it

It also removes 3.6 from tests as it is EOL and adds 3.9 and 3.10

StarrFox avatar Oct 13 '22 15:10 StarrFox

the test failure seems to be because it thinks python is 2.7? I'm not sure why this happens

re: https://ci.appveyor.com/project/srounet/pymem/builds/45061493/job/huhusjsgefgxbpan

python --version Python 2.7.17

StarrFox avatar Oct 13 '22 16:10 StarrFox

I need to learn more about poetry and see how it would benefits to pymem

srounet avatar Oct 13 '22 17:10 srounet

~~seems I'm still getting trolled by appveyor https://ci.appveyor.com/project/srounet/pymem/builds/48612762/job/jcb4t99y8wn3pabe~~ when I merged the branches it got the old content back

StarrFox avatar Nov 27 '23 00:11 StarrFox

finally working with appveyor

StarrFox avatar Nov 27 '23 01:11 StarrFox

I'm still not familiar with poetry, but I've heard good things about it.

As long as it des not break the automatic release process, I see no reasons why not to merge it.

srounet avatar Nov 28 '23 11:11 srounet

think this is ready to merge now, anyone see any other issues?

StarrFox avatar Nov 28 '23 23:11 StarrFox

this check failure just seems like appveyor trolling again, the same things passed on the "branch" version

I think it just timed out or something

StarrFox avatar Nov 29 '23 00:11 StarrFox

Is it possible to just restart the job? Might need srounet to do it if you don't have permission, or just push some other trivial change to force it to re-run...

monkeyman192 avatar Nov 29 '23 04:11 monkeyman192

I think it's fine to ignore since they passed for the branch set, @srounet ok to merge this?

StarrFox avatar Nov 29 '23 04:11 StarrFox

I think it's fine to ignore since they passed for the branch set, @srounet ok to merge this?

This will be something that should be easier to manage once it's moved to github actions I think...

monkeyman192 avatar Nov 29 '23 04:11 monkeyman192

I think it's fine to ignore since they passed for the branch set, @srounet ok to merge this?

This will be something that should be easier to manage once it's moved to github actions I think...

hoping to start working on that after this is merged

StarrFox avatar Nov 29 '23 04:11 StarrFox

looks ready to merge to me

StarrFox avatar Jan 01 '24 00:01 StarrFox