hubot-vtr-scripts icon indicating copy to clipboard operation
hubot-vtr-scripts copied to clipboard

Published 20 hours ago • verified publisher icon sroberts

Merge geoip commands into one

Open patcon opened this issue 11 years ago • 4 comments
trafficstars

Re: https://speakerdeck.com/sroberts/using-robots-to-fight-bad-guys?slide=50

https://github.com/sroberts/hubot-vtr-scripts/blob/master/src/scripts/rhodey-geo-maxmind.coffee https://github.com/sroberts/hubot-vtr-scripts/blob/master/src/scripts/rhodey-geo-ipinfo.coffee

Thoughts on merging into one so that hubot geo polls all services and provides an aggregate response or tabled data? Could always filter with hubot geo maxmind.

patcon avatar Dec 11 '13 21:12 patcon

:+1: agree!

mattjay avatar Dec 11 '13 21:12 mattjay

I can understand that, but the reasoning was to demonstrate two different techniques. I still think there's value in showing that, but I'd rather get away from this redundant example.

I'm not sure what examples off the expanded list could be ported to Python, @technoskald, any ideas?

sroberts avatar Dec 11 '13 22:12 sroberts

So do you want VTR to be a teaching tool or a useful tool? I tend to lean towards @patcon 's suggestion: poll all services with hubot geo and allow the user to specify maxmind or ipinfo if only one is desired.

To my mind, this fits the general approach of "tell me what I need to know" in a conversational-ish interface, same as we'd eventually like to do for reputation lookups and such.

krmaxwell avatar Dec 11 '13 22:12 krmaxwell

@sroberts maybe leave these scripts as is and make a 3rd that does just "geo" which calls both? Just for demo purposes until we have more things on Rhodey.

I'm researching getting the SSL thing done now but the tool I was planning on using is not open source nor does it have an open API. Once I figure it out though it might help replace as a demonstration script.

mattjay avatar Dec 11 '13 23:12 mattjay