containerlab icon indicating copy to clipboard operation
containerlab copied to clipboard

Linux containers not cleaned up after VM reboot

Open jbemmel opened this issue 3 years ago • 2 comments

Suspected cause: https://github.com/srl-labs/containerlab/blob/2d6d77baf9b7c9b15cfdc93c19f74bbf37679a20/runtime/docker/docker.go#L411

When the host system reboots, most containers are removed but a set of Linux containers remains running in isolation

jbemmel avatar Oct 07 '22 12:10 jbemmel

As you can see, the reason is in the comment section. Some management containers (like telemetry stack) may fail over time and the automatic restart beings them back without human intervention.

Rebooting a node with a lab running is considered to be an incident, and a manual clean up is expected. Luckily it is a single line bash script

On Fri, 7 Oct 2022 at 14:31, J vanBemmel @.***> wrote:

Suspected cause: https://github.com/srl-labs/containerlab/blob/2d6d77baf9b7c9b15cfdc93c19f74bbf37679a20/runtime/docker/docker.go#L411

When the host system reboots, most containers are removed but a set of Linux containers remains running in isolation

— Reply to this email directly, view it on GitHub https://github.com/srl-labs/containerlab/issues/1055, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLKV5NLT4DT5PGF5IED6RTWCAJYTANCNFSM6AAAAAAQ7RSRT4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

hellt avatar Oct 07 '22 13:10 hellt

I would still like to be able to disable this through configuration. When building automated topologies with several simple linux host containers, I prefer them to be cleaned up like the other non-linux containers, and not stick around

Suggestion: auto-remove: yes

See https://github.com/srl-labs/containerlab/pull/1056 (applied to all kinds, avoids restart policy when 'yes')

jbemmel avatar Oct 07 '22 20:10 jbemmel

thanks

hellt avatar Oct 16 '22 11:10 hellt