go-billy icon indicating copy to clipboard operation
go-billy copied to clipboard

osfs should implement billy.Changer

Open rydrman opened this issue 7 years ago • 3 comments

I have been loving this abstraction that you guys have created so kudos to that! Trying to change the permissions on a file using the osfs but it seems that it doesn't implement the billy.Changer interface. I was looking into making some changes for this but the relationship between the osfs.OS type and the chroot seems to mess it up a little since I guess we don't want the ChrootHelper to assume the given underlying fs is a changer... Any insight into how I might go about this would be greatly appreciated.

rydrman avatar Apr 04 '18 23:04 rydrman

@rydrman It can always implement the function and return ErrNotSupported if the underlying filesystem does not support it.

@mcuadros what do you think?

smola avatar Aug 01 '18 14:08 smola

If we add Change interface to Filesystem will force 3rd party implementation change

mcuadros avatar Sep 21 '18 05:09 mcuadros

Not add Change into Filesystem interface, but implement Changer interface on osfs implementation will not break backward compatibility.

ajnavarro avatar Sep 21 '18 08:09 ajnavarro