workflow-kotlin

workflow-kotlin copied to clipboard

Compose Multiplatform Support

1

# Overview This pull request add Kotlin Multiplatform (KMP) support for the `workflow-ui:compose` module. Some of the most notable changes are the `build.gradle.kts` configurations and changing/adding targets e.g. `androidMain` vs...

blakelee

I should make a separate pass to catch old `rendering: Screen` instances :/ _Originally posted by @rjrjr in https://github.com/square/workflow-kotlin/pull/1207#discussion_r1659078192_

rjrjr

The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed. You don't need to merge this PR...

renovate[bot]

rjrjr

Missing from `ScreenComposableFactoryFinder`. ```kotlin // Support for Compose BackStackScreen, BodyAndOverlaysScreen treatments would go here, // if it were planned. See similar blocks in ScreenViewFactoryFinder ?: (rendering as? BackButtonScreen)?.let { ScreenComposableFactory...

rjrjr

That method is supposed to report any user interaction in the app, but it ignores `Dialog` windows. (`DialogFragment` reportedly has the same problem.) The fix is really simple, see [this...

rjrjr

Add an option to get the next action that is mutually exclusive to the dirty nodes. Then we can apply as many of those actions as possible. Add tests for...

steve-the-edwards

1311:Use Compose's AndroidUiDispatcher.Main to conflate actions in runtime.

1

Note this also includes some adjustments to the runtime loop. After the first suspension to wait and apply an action, with `CONFLATE_STALE_RENDERINGS` we loop without suspending - applying any actions...

steve-the-edwards

Start using Burst anywhere we parametrize tests. This will help prep for adding new runtime configs in one place.

steve-the-edwards

On Android, process all updates from actions from an event before the next frame (Choreographer.doFrame)

5

We use an inner loop for `CONFLATE_STALE_RENDERINGS` and `DRAIN_EXCLUSIVE_ACTIONS` ([here](https://github.com/square/workflow-kotlin/pull/1269)) to apply multiple actions in one render pass (or in the case of CSR, in one 'UI update'). When the...

steve-the-edwards