workflow-kotlin icon indicating copy to clipboard operation
workflow-kotlin copied to clipboard

Compose's insets are lost through a backstack container

Open Kernald opened this issue 3 years ago • 3 comments
trafficstars

When using a certain configuration of nested workflows (I haven't found exactly the logic there), involving a backstack container (it might be a red herring I guess), Compose's insets are not propagated.

There's a repro here.

In MainActivity.kt/HelloComposeModel, the first workflow that's started is NavigationWorkflow, which in turns starts BackStackWorkflow either with or without a backstack - the insets are missing if there's a backstack. However, if HelloComposeModel starts NavigationWorkflow directly, regardless of with or without a backstack, everything works just fine.

This started appearing after an upgrade to Compose 1.2.0, insets were previously part of Accompanist and went through quite a bit of a change (https://google.github.io/accompanist/insets/#migration-table).

Kernald avatar Aug 03 '22 12:08 Kernald

cc @rjrjr I remember seeing something related to this in your UI work recently?

steve-the-edwards avatar Aug 03 '22 17:08 steve-the-edwards

I wonder if this has something to do with view/compose interop?

zach-klippenstein avatar Aug 03 '22 17:08 zach-klippenstein

I'm not 100% done with my migration just yet but it seems this might be fixed with Compose 1.3.0. I'll try updating my repro repo linked above to confirm.

Kernald avatar Oct 24 '22 22:10 Kernald