workflow-kotlin icon indicating copy to clipboard operation
workflow-kotlin copied to clipboard

[kotlin] Stacktraces from WorkflowTester timeouts are useless

Open zach-klippenstein opened this issue 5 years ago • 3 comments
trafficstars

Timeout exceptions thrown from the coroutine library's withTimeout function are useless. We should catch and re-throw with a real exception that has a real stacktrace.

zach-klippenstein avatar Feb 07 '20 06:02 zach-klippenstein

The comment on this issue makes it sound like this should be fixed already, but apparently it is not: https://github.com/Kotlin/kotlinx.coroutines/issues/1625#issuecomment-544917309

zach-klippenstein avatar Feb 07 '20 06:02 zach-klippenstein

Since it affects which exceptions we expose, I would consider this as an API change even though it's technically not.

zach-klippenstein avatar Jun 12 '20 23:06 zach-klippenstein

Not API change, not 1.0 blocker.

zach-klippenstein avatar Jun 27 '20 00:06 zach-klippenstein