workflow-kotlin icon indicating copy to clipboard operation
workflow-kotlin copied to clipboard

wrap Activity and Compose rules in LeakCanary checks on both sides

Open RBusarow opened this issue 3 years ago • 3 comments
trafficstars

I'm open to bike-shedding the name. 😄

fixes #657

RBusarow avatar Feb 02 '22 23:02 RBusarow

One thing to note: all the changes here (and in internal forks of the rule) have been backported to LeakCanary which will soon be released as 2.9. You'll need to adapt the code a bit but should be able to delete this custom rule.

https://github.com/square/leakcanary/blob/main/leakcanary-android-instrumentation/src/main/java/leakcanary/DetectLeaksAfterTestSuccess.kt

pyricau avatar Apr 19 '22 21:04 pyricau

@RBusarow Any plans to update this to LC 2.9 and get it merged?

rjrjr avatar Jun 10 '22 22:06 rjrjr

@RBusarow Any plans to update this to LC 2.9 and get it merged?

Yeah, I'll get this updated soon. I took a stab at it a while ago and was running into leaks in the compose activity rule, but didn't have the time to dig into it.

RBusarow avatar Jun 13 '22 14:06 RBusarow