workflow-kotlin icon indicating copy to clipboard operation
workflow-kotlin copied to clipboard

Published 20 hours ago • verified publisher icon square

Resolve running(Worker) inconsistencies

Open zach-klippenstein opened this issue 5 years ago • 2 comments
trafficstars 

MyWorker()
  .running(context, "key")

This requires turning Worker in Kotlin into an abstract class and making Worker.run protected, to reduce confusion.

We need to something similar for Workflow, see square/workflow#996.

zach-klippenstein avatar Mar 10 '20 21:03 zach-klippenstein

Fixed on the swift side.

dhavalshreyas avatar Jul 02 '20 21:07 dhavalshreyas

We decided to remove this from 1.0 in kotlin since it just added work and confusion and we didn't think this was a very important detail to converge on.

zach-klippenstein avatar Jul 05 '20 17:07 zach-klippenstein