FreeSimpleGUI icon indicating copy to clipboard operation
FreeSimpleGUI copied to clipboard

Bug Found from PySimpleGUI spin element

Open robochopbg opened this issue 1 year ago • 0 comments

Windows 10 FreeSimpleGUI / PySimpleGUI

The issue is with the sg.Spin element when holding down either up or down arrows buttons continuously. When you release the mouse button or <ButtonRelease-1>, the final value would of not been captured internally unless i suppose you do an additional write_event_value or whatever.

sg.Spin(
    values=[i for i in range(21)], 
    size=(2, 1), 
    font="Arial 9", 
    background_color=bgc, 
    enable_events=True, 
    readonly=True, 
    k="Lockout", 
    p=((8, 0), (30, 0))
)

in my code im busy with i cannot click additional time to get the final value using element.get()

So here if i start the default value as 5 and then hold down mouse button on the up arrow button in the spinbox. When it reaches 20 and i let go the mouse button, i dont get the value 20 from call element.get() and infact while holding down the mouse button there are no more events fired for the spinbox.

They guys from PySimpleGUI actually had the correct code but then messed it up.

In the main __init__.py file find under element spin

if element.ChangeSubmits:
    element.TKSpinBox.configure(command=element._SpinboxSelectHandler)   -----   This needs to be commented out
    # element.TKSpinBox.bind('<ButtonRelease-1>', element._SpinChangedHandler) --- enable this again but use _SpinboxSelectHandler
    # element.TKSpinBox.bind('<Up>', element._SpinChangedHandler) --- leave as is
    # element.TKSpinBox.bind('<Down>', element._SpinChangedHandler) ---- leave as is

For me doing this fixed the spinbox.

Also this internal method _SpinChangedHandler from the class Spin is pointless at the moment as it does not get called anywhere because they changed to using _SpinboxSelectHandler.

robochopbg avatar Nov 06 '24 08:11 robochopbg