compose-data-table icon indicating copy to clipboard operation
compose-data-table copied to clipboard

Support for wasmJs

Open ptitjes opened this issue 1 year ago • 3 comments
trafficstars

Hi Sean, I started using your library in my app. And I must say it is great!!

The only thing I am really missing currently is the wasmJs and ios* targets.

Looking at your build files and version catalogue, I see nothing that would prevent it. Could you please add those targets?

ptitjes avatar Sep 01 '24 17:09 ptitjes

I can certainly add the wasmJs target. iOS targets need to be built on a Mac, which I don't use for development. I could use GH actions to build the releases. This is a bit more time than I'd like to invest at the moment in supporting a target that I am not currently using. If you create a PR that adds the targets and a GH action to publish, I'll certainly accept it. Currently to publish I just run ./gradlew publishAndReleaseToMavenCentral.

sproctor avatar Sep 01 '24 19:09 sproctor

I can certainly add the wasmJs target. iOS targets need to be built on a Mac, which I don't use for development. I could use GH actions to build the releases. This is a bit more time than I'd like to invest at the moment in supporting a target that I am not currently using.

That's fair! I would be very happy with the wasmJs target already! :smile:

If you create a PR that adds the targets and a GH action to publish, I'll certainly accept it. Currently to publish I just run ./gradlew publishAndReleaseToMavenCentral.

I'll look into it. Thank you!

ptitjes avatar Sep 02 '24 12:09 ptitjes

Thanks to @eyedol, we have iOS support in 0.10.1.

sproctor avatar Dec 28 '24 21:12 sproctor

I added a wasm target in 0.11.4. Let me know if it works

sproctor avatar May 28 '25 15:05 sproctor