GTKUI prefs page fix.

[mhertz]

Sorry for being to lazy to make PR, but here's a diff patch for needed changes to get GTKUI preferences page to show and not output errors:

https://paste.c-net.org/OscarDivision

It's missing alot of options though currently, but better than nothing of-course.

I made builds including this, plus screenshots, and posted on the forum here:

https://forum.deluge-torrent.org/viewtopic.php?f=9&t=47243&start=210#p233413

Thanks again for your work.

[mhertz]

Sorry, just wanted to quickly add that there was additional issue missing from the diff I posted previously - line 295 in gtk3ui.py blocks deluge preferences from using 'Apply' or 'Ok' and only 'Cancel' work, so from error message in terminal/log, I changed additionally: '*.get_active_text()' to *.'get_active()'. It states otherwise no combobox attribute for get_active_text() or something. I changed it to how you used it in several other lines instead, though see there is a get_active_text() regardless, but anyway, atleast doesn't block preferences anymore.

Btw, I just noticed that in addition to the missing options, then also there is missing the option for selecting 'and', 'or' or 'xor', in the two conditions lower down i.e. the field/dropdown is empty, so don't know what it defaults too, as haven't tested it really.

Thanks.

[springjools]

Ok, I have a really busy time at work but tomorrow is Friday and then i can hopefully fix this:)

Sent from my iPhone

On 6 May 2021, at 16:59, Martin Hertz @.***> wrote:

 Sorry, just wanted to quickly add that there was additional issue missing from the diff I posted previously - line 295 in gtk3ui.py blocks deluge preferences from using 'Apply' or 'Ok' and only 'Cancel' work, so from error message in terminal/log, I changed additionally: '*.get_active_text()' to *.'get_active()'. It states otherwise no combobox attribute for get_active_text() or something. I changed it to how you used it in several other lines instead, though see there is a get_active_text() regardless, but anyway, atleast doesn't block preferences anymore.

Btw, I just noticed that in addition to the missing options, then also there is missing the option for selecting 'and', 'or' or 'xor', in the two conditions lower down i.e. the field/dropdown is empty, so don't know what it defaults too, as haven't tested it really.

Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[mhertz]

Thanks alot for reply Pontus, much appreciated :)

The issue in last post, was "and/or" not showing up in GTKUI prefs, and my "fix" didn't help, but fixed it now with help from tote94's code I wen't over and compared to yours, so now "and/or" works, but no "xor", as tote94 didn't have such.

Here's the updated diff patch, where there's 4 more lines or so changed/added: https://paste.c-net.org/DrokkenCanin

Please take your time, no hurry, just whenever time/life allows, of-course.

If I find anything else in mean time, then i'll edit this post here, to not spam your inbox :)

Let me know if I can do something to help or test :)

Thanks again.

Edit: Additional fix adding 'xor' also in GTKUI prefs, which I included in the diff patch: https://paste.c-net.org/PyramidsCongo

Edit2: Added more missing stuff to GTKUI prefs e.g. 'remove seedtime', 'pause seedtime', 'seed remove data' and 'pause torrents. It's not done very good mind you, e.g. options sorted little strange now etc'. I didn't include in the other diff patch, as not sure you can use this, but just in case here's seperate diff patch for this: https://paste.c-net.org/PartiedCorwin

[springjools]

Hey, sorry for late response, but I tried applying this patch now, but git fails to detect patch version. Or is it meant to be applied manually? Sorry if stupid question.

[mhertz]

No worries mate, and not stupid question :) Yeah, sorry manual, I always just use diff and patch, as not that good at git yet honestly. It's just a standard unified diff patch.

[mhertz]

I'm sorry, I just tested to make sure, and found I had the clone dir additionally added into the 'a' and 'b' dirs, instead of 'a' and 'b' being the clone dirs itself doh!

Anyway tested these all work:

~/deluge-autoremoveplus $ git apply -p2 ../diff.patch

~/deluge-autoremoveplus $ patch -p2 < ../diff.patch

~/deluge-autoremoveplus $ curl https://paste.c-net.org/PyramidsCongo | git apply -p2

~/deluge-autoremoveplus $ curl https://paste.c-net.org/PyramidsCongo | patch -p2

Note if building a release at some point, then if using setup.py and not just zipping up the two dirs, then python-setuptools 57 triggers an error in deluge whenever enabling plugin, because of metadata module/spec change, so I downgrade to 56.2.0-1 package when building/posting a modded plugin(before found reason I just zipped up dirs instead) - I did report it on deluge bugtracker, and didn't found other ways to fix than downgrade python-setuptools(well, deluge could be fixed but in mean time I mean) i.e. no matter if omiting description/long-description or whatever else fiddling about, still adds a description, either defined or UNKNOWN into payload data, making deluge show this error, and needs code-change to deluge to fix e.g. as I posted in deluge bug-report: https://dev.deluge-torrent.org/ticket/3476

Thanks again, take your time of-course :)

[neo-neo1]

Was this fix ever merged? It's been quite some time. If you have some time the Deluge community would appreciate it @springjools