spring-shell icon indicating copy to clipboard operation
spring-shell copied to clipboard

Published 20 hours ago • verified publisher icon spring-projects

Quotes Should Not Be Recognized In Comments

Open jlevy-bigfootbiomedical opened this issue 6 years ago • 2 comments
trafficstars

Both double and single quotes are recognized (or "active") inside of comments, which I think is a bug. The following two line Spring Shell script will not print help: // don't do this help

And if you put those two lines in a file, and try to run it with the at-sign on the command line, it will crash and you will get this: Caused by: org.jline.reader.EOFError: Missing closing quote

jlevy-bigfootbiomedical avatar Apr 03 '19 23:04 jlevy-bigfootbiomedical

I also have found this to be a problem, especially when running script files as mentioned.

Is there a way to up-vote a fix for this? If someone can point to where this might be broken (spring shell vs jLine) maybe I can dig into a fix.

dougbot01 avatar Dec 18 '19 16:12 dougbot01

Dear colleagues, I've created a PR to fix this issue. Could you please approve merging if there are no objections. @jvalkeal

polo7 avatar Jun 08 '24 00:06 polo7