spring-shell icon indicating copy to clipboard operation
spring-shell copied to clipboard

Implements equals and hash code overrides for completion proposal

Open jphughes88 opened this issue 6 years ago • 4 comments
trafficstars

Added with @georgiacarr1999

jphughes88 avatar Dec 18 '18 14:12 jphughes88

@jphughes88 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster avatar Dec 18 '18 14:12 pivotal-issuemaster

@jphughes88 Thank you for signing the Contributor License Agreement!

pivotal-issuemaster avatar Dec 18 '18 14:12 pivotal-issuemaster

Codecov Report

Merging #244 into master will decrease coverage by 0.02%. The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #244      +/-   ##
============================================
- Coverage     48.91%   48.88%   -0.03%     
- Complexity      252      255       +3     
============================================
  Files            53       53              
  Lines          1333     1342       +9     
  Branches        204      210       +6     
============================================
+ Hits            652      656       +4     
+ Misses          625      623       -2     
- Partials         56       63       +7
Impacted Files Coverage Δ Complexity Δ
.../org/springframework/shell/CompletionProposal.java 51.72% <22.22%> (-3.28%) 8 <2> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ec5899...089d7c3. Read the comment docs.

codecov-io avatar Dec 18 '18 14:12 codecov-io

@ericbottard Wonder if you could help with this PR, wondering about the coverage. Is it usual for you to write tests against POJO's or should the class be added to an exclusion list?

If you are not the right person, firstly, apologies, secondly are you able to point us in the right direction? I wasn't able to find any contributing docs with an IRC or slack channel etc...

stephen-murby avatar Dec 19 '18 09:12 stephen-murby