spring-session icon indicating copy to clipboard operation
spring-session copied to clipboard

hazelcast4 is not included in sources.jar, but in the lib jar

Open trydofor opened this issue 4 years ago • 3 comments

Describe the bug

both 2.4.3 & 2.5.0, the lib jar contains hazelcast4*, but the sources.jar does Not.

the lib jar contains the class from both (1) & (2),but the sources.jar missing (1)

  • (1)spring-session/spring-session-hazelcast/hazelcast4/hazelcast4.gradle
  • (2)spring-session/spring-session-hazelcast/spring-session-hazelcast.gradle

To Reproduce

diff the lib jar and source jar.

  1. download them by maven or http
  2. unzip them
  3. diff them

Expected behavior

keep the lib jar and sources.jar same.

trydofor avatar May 26 '21 03:05 trydofor

Thanks for bringing this up @trydofor. I believe this is because of the way we are packaging the Hazelcast 4 module, in order to support Hazelcast 4 and Hazelcast 3 simultaneously. Is this causing any serious issues for you?

eleftherias avatar May 31 '21 14:05 eleftherias

Thanks for bringing this up @trydofor. I believe this is because of the way we are packaging the Hazelcast 4 module, in order to support Hazelcast 4 and Hazelcast 3 simultaneously. Is this causing any serious issues for you?

Glad i can help, No inconvenience.

trydofor avatar Jun 02 '21 12:06 trydofor

Thanks @trydofor, I have scheduled this for the 3.x release, when we fully move to Hazelcast 4.

eleftherias avatar Jun 03 '21 14:06 eleftherias