spring-modulith icon indicating copy to clipboard operation
spring-modulith copied to clipboard

Expose stream/List of Events for incompleteEventPublications

Open zikozee opened this issue 1 year ago • 2 comments
trafficstars

I am looking at a scenario where I can dynamically batch the incomplete events which can also give room to do some extra work before or after.

zikozee avatar May 05 '24 04:05 zikozee

@odrotbohm - the thing mentioned here is that CompletedEventPublications interface exposes a method findAll() which would return all completed event publications, but IncompleteEventPublications does not provide such a method and there's a need to inject EventPublicationRegistry (e.g. in tests) to assert anything related to incomplete publications.

This difference might be misleading in my opinion.

I could try handling this and opening a pull request with that, what do you think about that?

patrzalektom avatar May 21 '24 21:05 patrzalektom

Mentioned pull request: https://github.com/spring-projects/spring-modulith/pull/616

patrzalektom avatar May 22 '24 06:05 patrzalektom