spring-modulith icon indicating copy to clipboard operation
spring-modulith copied to clipboard

Modulith Observability tags not added to OpenTelemetry tracing

Open tomdevroomen opened this issue 7 months ago • 0 comments
trafficstars

When using io.opentelemetry.instrumentation:opentelemetry-spring-boot-starter the Modulith tags aren't added to the span.

Although from logging I see the ModuleEntryInterceptor doing it's work, nothing shows up in the trace when being exported.

I used the Spring PetClinic and added:

<dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>org.springframework.modulith</groupId>
        <artifactId>spring-modulith-bom</artifactId>
        <version>1.3.4</version>
        <scope>import</scope>
        <type>pom</type>
      </dependency>
      <dependency>
        <groupId>io.opentelemetry.instrumentation</groupId>
        <artifactId>opentelemetry-instrumentation-bom</artifactId>
        <version>2.14.0</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>

  <dependencies>
    <dependency>
      <groupId>org.springframework.modulith</groupId>
      <artifactId>spring-modulith-starter-core</artifactId>
    </dependency>
    <dependency>
      <groupId>org.springframework.modulith</groupId>
      <artifactId>spring-modulith-starter-insight</artifactId>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>io.opentelemetry.instrumentation</groupId>
      <artifactId>opentelemetry-spring-boot-starter</artifactId>
    </dependency>
  </dependencies>
2025-03-28T16:40:59.963+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Entering Owner via o.s.s.p.o.OwnerController.setAllowedFields(…).
2025-03-28T16:40:59.964+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Leaving Owner
2025-03-28T16:40:59.965+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Entering Owner via o.s.s.p.o.OwnerController.findOwner(…).
2025-03-28T16:40:59.965+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Entering Owner via o.s.s.p.o.OwnerRepository.findById(…).
2025-03-28T16:40:59.969+01:00  INFO 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]i.o.e.logging.LoggingSpanExporter        : 'HikariDataSource.getConnection' : 62569891f19cd987b59a2f6480a5e0a8 55c56e11532206a1 INTERNAL [tracer: io.opentelemetry.jdbc:2.14.0-alpha] AttributesMap{data={db.name=b1dd168e-bba3-4112-9bc3-5658dbe7c3d4, db.connection_string=h2:mem:, code.namespace=com.zaxxer.hikari.HikariDataSource, code.function=getConnection, db.system=h2}, capacity=128, totalAddedValues=5}
2025-03-28T16:40:59.974+01:00  INFO 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]i.o.e.logging.LoggingSpanExporter        : 'SELECT b1dd168e-bba3-4112-9bc3-5658dbe7c3d4' : 62569891f19cd987b59a2f6480a5e0a8 706d3a6cd3d36e3a CLIENT [tracer: io.opentelemetry.jdbc:2.14.0-alpha] AttributesMap{data={db.operation=SELECT, db.name=b1dd168e-bba3-4112-9bc3-5658dbe7c3d4, db.connection_string=h2:mem:, db.statement=select o1_0.id,o1_0.address,o1_0.city,o1_0.first_name,o1_0.last_name,o1_0.telephone,p1_0.owner_id,p1_0.id,p1_0.birth_date,p1_0.name,t1_0.id,t1_0.name from owners o1_0 left join pets p1_0 on o1_0.id=p1_0.owner_id left join types t1_0 on t1_0.id=p1_0.type_id where o1_0.id=? order by p1_0.name, db.system=h2}, capacity=128, totalAddedValues=5}
2025-03-28T16:40:59.981+01:00  INFO 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]i.o.e.logging.LoggingSpanExporter        : 'SELECT b1dd168e-bba3-4112-9bc3-5658dbe7c3d4.visits' : 62569891f19cd987b59a2f6480a5e0a8 56bb8cd14040848c CLIENT [tracer: io.opentelemetry.jdbc:2.14.0-alpha] AttributesMap{data={db.sql.table=visits, db.operation=SELECT, db.name=b1dd168e-bba3-4112-9bc3-5658dbe7c3d4, db.connection_string=h2:mem:, db.statement=select v1_0.pet_id,v1_0.id,v1_0.visit_date,v1_0.description from visits v1_0 where v1_0.pet_id=? order by v1_0.visit_date, db.system=h2}, capacity=128, totalAddedValues=6}
2025-03-28T16:40:59.981+01:00  INFO 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]i.o.e.logging.LoggingSpanExporter        : 'SELECT b1dd168e-bba3-4112-9bc3-5658dbe7c3d4.visits' : 62569891f19cd987b59a2f6480a5e0a8 e0407f754806321c CLIENT [tracer: io.opentelemetry.jdbc:2.14.0-alpha] AttributesMap{data={db.sql.table=visits, db.operation=SELECT, db.name=b1dd168e-bba3-4112-9bc3-5658dbe7c3d4, db.connection_string=h2:mem:, db.statement=select v1_0.pet_id,v1_0.id,v1_0.visit_date,v1_0.description from visits v1_0 where v1_0.pet_id=? order by v1_0.visit_date, db.system=h2}, capacity=128, totalAddedValues=6}
2025-03-28T16:40:59.982+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Leaving Owner
2025-03-28T16:40:59.982+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Leaving Owner
2025-03-28T16:40:59.982+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Entering Owner via o.s.s.p.o.OwnerController.setAllowedFields(…).
2025-03-28T16:40:59.982+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Leaving Owner
2025-03-28T16:40:59.982+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Entering Owner via o.s.s.p.o.OwnerController.showOwner(…).
2025-03-28T16:40:59.982+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Entering Owner via o.s.s.p.o.OwnerRepository.findById(…).
2025-03-28T16:40:59.982+01:00  INFO 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]i.o.e.logging.LoggingSpanExporter        : 'HikariDataSource.getConnection' : 62569891f19cd987b59a2f6480a5e0a8 c028dd82049b945d INTERNAL [tracer: io.opentelemetry.jdbc:2.14.0-alpha] AttributesMap{data={db.name=b1dd168e-bba3-4112-9bc3-5658dbe7c3d4, db.connection_string=h2:mem:, code.namespace=com.zaxxer.hikari.HikariDataSource, code.function=getConnection, db.system=h2}, capacity=128, totalAddedValues=5}
2025-03-28T16:40:59.983+01:00  INFO 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]i.o.e.logging.LoggingSpanExporter        : 'SELECT b1dd168e-bba3-4112-9bc3-5658dbe7c3d4' : 62569891f19cd987b59a2f6480a5e0a8 98464e081c045f66 CLIENT [tracer: io.opentelemetry.jdbc:2.14.0-alpha] AttributesMap{data={db.operation=SELECT, db.name=b1dd168e-bba3-4112-9bc3-5658dbe7c3d4, db.connection_string=h2:mem:, db.statement=select o1_0.id,o1_0.address,o1_0.city,o1_0.first_name,o1_0.last_name,o1_0.telephone,p1_0.owner_id,p1_0.id,p1_0.birth_date,p1_0.name,t1_0.id,t1_0.name from owners o1_0 left join pets p1_0 on o1_0.id=p1_0.owner_id left join types t1_0 on t1_0.id=p1_0.type_id where o1_0.id=? order by p1_0.name, db.system=h2}, capacity=128, totalAddedValues=5}
2025-03-28T16:40:59.983+01:00  INFO 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]i.o.e.logging.LoggingSpanExporter        : 'SELECT b1dd168e-bba3-4112-9bc3-5658dbe7c3d4.visits' : 62569891f19cd987b59a2f6480a5e0a8 280b2ea80e6f78d9 CLIENT [tracer: io.opentelemetry.jdbc:2.14.0-alpha] AttributesMap{data={db.sql.table=visits, db.operation=SELECT, db.name=b1dd168e-bba3-4112-9bc3-5658dbe7c3d4, db.connection_string=h2:mem:, db.statement=select v1_0.pet_id,v1_0.id,v1_0.visit_date,v1_0.description from visits v1_0 where v1_0.pet_id=? order by v1_0.visit_date, db.system=h2}, capacity=128, totalAddedValues=6}
2025-03-28T16:40:59.984+01:00  INFO 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]i.o.e.logging.LoggingSpanExporter        : 'SELECT b1dd168e-bba3-4112-9bc3-5658dbe7c3d4.visits' : 62569891f19cd987b59a2f6480a5e0a8 6e2c624caf5888b2 CLIENT [tracer: io.opentelemetry.jdbc:2.14.0-alpha] AttributesMap{data={db.sql.table=visits, db.operation=SELECT, db.name=b1dd168e-bba3-4112-9bc3-5658dbe7c3d4, db.connection_string=h2:mem:, db.statement=select v1_0.pet_id,v1_0.id,v1_0.visit_date,v1_0.description from visits v1_0 where v1_0.pet_id=? order by v1_0.visit_date, db.system=h2}, capacity=128, totalAddedValues=6}
2025-03-28T16:40:59.985+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Leaving Owner
2025-03-28T16:40:59.985+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Leaving Owner
2025-03-28T16:40:59.986+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Entering Owner via o.s.s.p.o.OwnerController.setAllowedFields(…).
2025-03-28T16:40:59.986+01:00 TRACE 55621 --- [petclinic] [nio-8080-exec-1] [trace_id=62569891f19cd987b59a2f6480a5e0a8, trace_flags=01, span_id=c312d03741e5a7a7]o.s.m.o.ModuleEntryInterceptor           : Leaving Owner
2025-03-28T16:40:59.998+01:00  INFO 55621 --- [petclinic] [nio-8080-exec-1] []i.o.e.logging.LoggingSpanExporter        : 'GET /owners/{ownerId}' : 62569891f19cd987b59a2f6480a5e0a8 c312d03741e5a7a7 SERVER [tracer: io.opentelemetry.spring-webmvc-6.0:2.14.0-alpha] AttributesMap{data={url.scheme=http, server.address=localhost, client.address=0:0:0:0:0:0:0:1, user_agent.original=Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/134.0.0.0 Safari/537.36, network.peer.address=0:0:0:0:0:0:0:1, url.path=/owners/3, http.response.status_code=200, http.request.method=GET, server.port=8080, network.protocol.version=1.1, network.peer.port=53872, http.route=/owners/{ownerId}}, capacity=128, totalAddedValues=12}

tomdevroomen avatar Mar 28 '25 15:03 tomdevroomen