spring-batch
spring-batch copied to clipboard
Correct comment in test examples
trafficstars
Changes:
- A comment line was unecessarily split, this PR seeks to improve the readability and clean that line comment up
This formatting is done by the spring-javaformat plugin, you can try it with: ./mvnw spring-javaformat:apply.
But we can make that comment more readable with something like:
// the manager sent 2 chunks ({1, 2, 3} and {4, 5, 6}) to workers
assertEquals("Waited for 2 results.", jobExecution.getExitStatus().getExitDescription());
If you update the PR accordingly, it should be good to merge.
Alright, thank you for explaining how the formatting was done!
After the suggested change, we have landed on this:
// then
// the manager sent 2 chunks ({1, 2, 3} and {4, 5, 6}) to workers
assertEquals(ExitStatus.COMPLETED.getExitCode(), jobExecution.getExitStatus().getExitCode());
However it could also look like below, which should be more readable as well, and plays well into the given, when and then
// then the manager sent 2 chunks ({1, 2, 3} and {4, 5, 6}) to workers
assertEquals(ExitStatus.COMPLETED.getExitCode(), jobExecution.getExitStatus().getExitCode());