Update the default value of skipLimit in FaultTolerantStepBuilder to 10

[Ian3110]

trafficstars

I have submitted a pull request addressing the issue described in #4661. The changes include updating the default value of skipLimit in FaultTolerantStepBuilder to 10.

[pivotal-cla]

@Ian3110 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-cla]

@Ian3110 Thank you for signing the Contributor License Agreement!

[fmbenhassine]

Thank you for opening this PR! The changes look good to me, however I got a build failure while testing the PR:

[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   ChunkElementParserTests.testCommitIntervalLateBinding:75 » BeanCreation Error creating bean with name 'org.springframework.batch.core.configuration.xml.SimpleFlowFactoryBean#0': Cannot create inner bean '(inner bean)#15c4b89b' of type [org.springframework.batch.core.job.flow.support.StateTransition] while setting bean property 'stateTransitions' with key [4]
[ERROR]   ChunkElementParserTests.testRetryPolicyAttribute:97 » BeanCreation Error creating bean with name 'org.springframework.batch.core.configuration.xml.SimpleFlowFactoryBean#0': Cannot create inner bean '(inner bean)#6ea48ca1' of type [org.springframework.batch.core.job.flow.support.StateTransition] while setting bean property 'stateTransitions' with key [0]
[ERROR]   ChunkElementParserTests.testRetryPolicyElement:109 » BeanCreation Error creating bean with name 'org.springframework.batch.core.configuration.xml.SimpleFlowFactoryBean#0': Cannot create inner bean '(inner bean)#1352211d' of type [org.springframework.batch.core.job.flow.support.StateTransition] while setting bean property 'stateTransitions' with key [0]
[ERROR]   ParentStepFactoryBeanParserTests.testRetryableAttributes:58 » BeanCreation Error creating bean with name 'org.springframework.batch.core.configuration.xml.SimpleFlowFactoryBean#0': Cannot create inner bean '(inner bean)#35cf7e98' of type [org.springframework.batch.core.job.flow.support.StateTransition] while setting bean property 'stateTransitions' with key [0]
[ERROR]   ParentStepFactoryBeanParserTests.testRetryableLateBindingAttributes:70 » BeanCreation Error creating bean with name 'org.springframework.batch.core.configuration.xml.SimpleFlowFactoryBean#0': Cannot create inner bean '(inner bean)#28dae87e' of type [org.springframework.batch.core.job.flow.support.StateTransition] while setting bean property 'stateTransitions' with key [0]
[ERROR]   ParentStepFactoryBeanParserTests.testSimpleAttributes:36 » BeanCreation Error creating bean with name 'org.springframework.batch.core.configuration.xml.SimpleFlowFactoryBean#0': Cannot create inner bean '(inner bean)#5cc088a8' of type [org.springframework.batch.core.job.flow.support.StateTransition] while setting bean property 'stateTransitions' with key [0]
[ERROR]   AbstractTaskletStepBuilderTests.testSetTaskExecutorAfterFaultTolerant:82 » IllegalState If a skip limit is provided then skippable exceptions must also be specified
[ERROR]   AbstractTaskletStepBuilderTests.testSetTaskExecutorBeforeFaultTolerant:67 » IllegalState If a skip limit is provided then skippable exceptions must also be specified
[ERROR]   FaultTolerantStepBuilderTests.testAnnotationBasedStepExecutionListenerRegistration:51 » IllegalState If a skip limit is provided then skippable exceptions must also be specified
[ERROR]   StepBuilderTests.testAnnotationBasedChunkListenerForFaultTolerantTaskletStep:154 » IllegalState If a skip limit is provided then skippable exceptions must also be specified
[ERROR]   StepBuilderTests.testFunctionsWithFaultTolerantStep:209->assertStepFunctions:228 » IllegalState If a skip limit is provided then skippable exceptions must also be specified
[ERROR]   FaultTolerantStepFactoryBeanRetryTests.testNoItemsReprocessedWhenErrorInWriterAndProcessorNotTransactional:268 » IllegalState If a skip limit is provided then skippable exceptions must also be specified
[ERROR]   FaultTolerantStepFactoryBeanRetryTests.testSuccessfulRetryWithReadFailure:300 » IllegalState If a skip limit is provided then skippable exceptions must also be specified
[ERROR]   FaultTolerantStepFactoryBeanUnexpectedRollbackTests.testTransactionException:96 » IllegalState If a skip limit is provided then skippable exceptions must also be specified
[INFO]
[ERROR] Tests run: 1618, Failures: 0, Errors: 14, Skipped: 14
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Spring Batch 5.2.0-SNAPSHOT:
[INFO]
[INFO] Spring Batch ....................................... SUCCESS [  2.009 s]
[INFO] Spring Batch Infrastructure ........................ SUCCESS [01:46 min]
[INFO] Spring Batch Core .................................. FAILURE [ 44.450 s]
[INFO] Spring Batch Test .................................. SKIPPED
[INFO] Spring Batch Integration ........................... SKIPPED
[INFO] Spring Batch Samples ............................... SKIPPED
[INFO] Spring Batch Docs .................................. SKIPPED
[INFO] Spring Batch BOM ................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

Can you please check and update the PR accordingly? It would be great if you squash all the commits as well. Thank you upfront.

[Ian3110]

Thanks for pointing out the problem!! I'm a bit busy right now, so I'll commit again in two weeks.

[fmbenhassine]

Rebased and merged as fd45d32239c65892c7e2e1fb2e67414bcb5eadb4. I also fixed the build in 6c330d6bd13dab495cd26173061a3ea76cfba962. Thank you for your contribution!