spring-batch icon indicating copy to clipboard operation
spring-batch copied to clipboard

Step names must be unique #3757

Open FBibonne opened this issue 1 year ago • 3 comments

  • test(check unicity of job name in a flow) failing test
  • test(check unicity of job name in a flow) step name as a job parameter
  • fix(log for tests) print log in console for tests
  • feat(step name unicity) #3757 the names of different steps in a job must be different

FBibonne avatar Feb 05 '24 21:02 FBibonne

Solves #3757

FBibonne avatar Feb 05 '24 21:02 FBibonne

WIP because 5 tests still fail

FBibonne avatar Feb 05 '24 21:02 FBibonne

All tests passed.

  • pom is updated to have a have a version of slf4j-api corresponding to simple-slf4j
  • unicity of names is checked when starting the job , just before calling listeners because step names may be known only in JobScope
  • in FlowJob.findStepsThrowingIfNameNotUnique, I suggest to remove the else block when state is instance of StepHolder : it is never executed

FBibonne avatar Feb 06 '24 07:02 FBibonne