spring-cloud-openfeign icon indicating copy to clipboard operation
spring-cloud-openfeign copied to clipboard

Delete '/' at the end of url

Open artem-gorshkov opened this issue 3 years ago • 4 comments
trafficstars

In situation when we create FeignClient in this way: @FeignClient(url = "https://localhost/", path = "api/v2") We will get an error because of adding '/' in the beginning of the path in FeignClientsRegistrar.getPath, result will: https://localhost//api/v2 To escape this situation we need to delete '/' at the end of url in FeignClientsRegistrar.getUrl

artem-gorshkov avatar Apr 28 '22 09:04 artem-gorshkov

@gorshik Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Apr 28 '22 09:04 pivotal-cla

@gorshik Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Apr 28 '22 09:04 pivotal-cla

@pivotal-cla This is an Obvious Fix

artem-gorshkov avatar Apr 28 '22 09:04 artem-gorshkov

Bug fixes like this don't typically qualify as an obvious fix

spencergibb avatar Apr 28 '22 15:04 spencergibb