spring-cloud-openfeign icon indicating copy to clipboard operation
spring-cloud-openfeign copied to clipboard

spring cloud 2023.0.5 dependency issue. This version bring feign-hc which has an dependency to hc-5.4.

Open alexisgayte opened this issue 9 months ago • 3 comments
trafficstars

spring cloud 2023.0.5 breaks the contract of bringing only patching versions.

by bringing hc-5.4 it also bring the non fixed issue or breaking change : https://github.com/orange-guo/spring-cloud-openfeign/commit/66d590cff227c37ddacae33110dbe76debce77b7

It also breaks the contract with spring boot 3.3.x which uses 5.3. https://docs.spring.io/spring-boot/3.3/appendix/dependency-versions/coordinates.html

alexisgayte avatar Feb 07 '25 16:02 alexisgayte

See d314ba81674cb7d60a4d98ed6d363200cf78158b

Maybe @OlgaMaciaszek knows

spencergibb avatar Feb 07 '25 17:02 spencergibb

Seems to have been brought in with 2023.0.4 - and the feign-hc version bump from 13.4 to 13.5.

https://github.com/OpenFeign/feign/blob/13.4/hc5/pom.xml https://github.com/OpenFeign/feign/blob/13.5/hc5/pom.xml

Thanks @spencergibb for pointing out that is also partly due to openfeign being nasty with you.

And I also wanted to thank you all (@OlgaMaciaszek ) for all the good job you are doing.

alexisgayte avatar Feb 10 '25 11:02 alexisgayte

Thanks for bringing this up, @alexisgayte. We do not manage hc5 version ourselves. It's been brought up by Feign. I will mark this issue for team discussion.

OlgaMaciaszek avatar Feb 10 '25 12:02 OlgaMaciaszek