spring-cloud-openfeign icon indicating copy to clipboard operation
spring-cloud-openfeign copied to clipboard

Published 20 hours ago • verified publisher icon spring-cloud

Add @QueryMap mapEncoder attribute

Open galaxy-sea opened this issue 1 year ago • 7 comments
trafficstars

Referenced feign#2098. I like this feature♥️.

galaxy-sea avatar Apr 01 '24 13:04 galaxy-sea

hello @OlgaMaciaszek , Can this PR be merged before the next release version? This feature allows for more flexible transformer DTO.

galaxy-sea avatar Apr 16 '24 01:04 galaxy-sea

Thanks for the PR, @galaxy-sea. We will definitely review it before the next release (not coming till mid May).

OlgaMaciaszek avatar Apr 16 '24 10:04 OlgaMaciaszek

Make sure to document your feature in spring-cloud-openfeign.adoc.

OlgaMaciaszek avatar Apr 18 '24 15:04 OlgaMaciaszek

hello @OlgaMaciaszek , I will change the implementation to @BaseQueryMapEncoder

galaxy-sea avatar May 03 '24 04:05 galaxy-sea

opt-in property flag

hi @OlgaMaciaszek , I don't think it's necessary to add opt in property flags, just using bean annotated as @ BaseQueryMapEncoder would be more reasonable

galaxy-sea avatar May 07 '24 14:05 galaxy-sea

@galaxy-sea the idea is to maintain it backwards compatible since we're not waiting for the major - the behaviour should not cause any breaking changes for existing users, hence the flag.

OlgaMaciaszek avatar May 09 '24 10:05 OlgaMaciaszek

Hello @galaxy-sea, please let us know if you're planning to continue working on this PR and add requested changes?

OlgaMaciaszek avatar Sep 27 '24 15:09 OlgaMaciaszek