spring-cloud-dataflow icon indicating copy to clipboard operation
spring-cloud-dataflow copied to clipboard

Published 20 hours ago • verified publisher icon spring-cloud

Refactor junit5 and assertj

Open jvalkeal opened this issue 4 years ago • 5 comments

This issue tracks a progress of moving fully on junit5 and assertj.

  • [ ] spring-cloud-dataflow-audit/src/test/java/org/springframework/cloud/dataflow/server/audit/service
  • [ ] spring-cloud-dataflow-autoconfigure/src/test/java/org/springframework/cloud/dataflow/autoconfigure/local
  • [ ] spring-cloud-dataflow-classic-docs/src/test/java/org/springframework/cloud/dataflow/server/rest/documentation
  • [ ] spring-cloud-dataflow-completion/src/test/java/org/springframework/cloud/dataflow/completion
  • [ ] spring-cloud-dataflow-composed-task-runner/src/test/java/org/springframework/cloud/dataflow/composedtaskrunner
  • [ ] spring-cloud-dataflow-composed-task-runner/src/test/java/org/springframework/cloud/dataflow/composedtaskrunner/properties
  • [ ] spring-cloud-dataflow-composed-task-runner/src/test/java/org/springframework/cloud/dataflow/composedtaskrunner/support
  • [ ] spring-cloud-dataflow-composed-task-runner/src/test/java/org/springframework/cloud/dataflow/composedtaskrunner/configuration
  • [ ] spring-cloud-dataflow-configuration-metadata/src/test/java/org/springframework/cloud/dataflow/container/registry/authorization
  • [ ] spring-cloud-dataflow-configuration-metadata/src/test/java/org/springframework/cloud/dataflow/container/registry/authorization/support
  • [ ] spring-cloud-dataflow-configuration-metadata/src/test/java/org/springframework/cloud/dataflow/configuration/metadata
  • [ ] spring-cloud-dataflow-container-registry/src/test/java/org/springframework/cloud/dataflow/container/registry/authorization
  • [ ] spring-cloud-dataflow-container-registry/src/test/java/org/springframework/cloud/dataflow/container/registry/authorization/support
  • [ ] spring-cloud-dataflow-core-dsl/src/test/java/org/springframework/cloud/dataflow/core/dsl
  • [ ] spring-cloud-dataflow-core/src/test/java/org/springframework/cloud/dataflow/core
  • [ ] spring-cloud-dataflow-platform-cloudfoundry/src/test/java/org/springframework/cloud/dataflow/server/config/cloudfoundry
  • [ ] spring-cloud-dataflow-platform-kubernetes/src/test/java/org/springframework/cloud/dataflow/server/config/kubernetes
  • [ ] spring-cloud-dataflow-registry/src/test/java/org/springframework/cloud/dataflow/registry/support
  • [ ] spring-cloud-dataflow-registry/src/test/java/org/springframework/cloud/dataflow/registry/service
  • [ ] spring-cloud-dataflow-rest-client/src/test/java/org/springframework/cloud/dataflow/rest/client
  • [ ] spring-cloud-dataflow-rest-client/src/test/java/org/springframework/cloud/dataflow/rest/client/dsl
  • [ ] spring-cloud-dataflow-rest-client/src/test/java/org/springframework/cloud/dataflow/rest/client/config
  • [ ] spring-cloud-dataflow-rest-resource/src/test/java/org/springframework/cloud/dataflow/rest/resource
  • [ ] spring-cloud-dataflow-rest-resource/src/test/java/org/springframework/cloud/dataflow/rest/util
  • [ ] spring-cloud-dataflow-rest-resource/src/test/java/org/springframework/cloud/dataflow/rest/job
  • [ ] spring-cloud-dataflow-rest-resource/src/test/java/org/springframework/cloud/dataflow/rest/job/support
  • [ ] spring-cloud-dataflow-rest-resource/src/test/java/org/springframework/cloud/dataflow/rest/support
  • [ ] spring-cloud-dataflow-rest-resource/src/test/java/org/springframework/cloud/dataflow/rest/support/jackson
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/repository
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/repository/support
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/registry
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/completion
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/support
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl/diff
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl/validation
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/config
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/config/features
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/stream
  • [ ] spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/configuration
  • [ ] spring-cloud-dataflow-server/src/test/java/org/springframework/cloud/dataflow/server/single
  • [ ] spring-cloud-dataflow-server/src/test/java/org/springframework/cloud/dataflow/integration/test
  • [ ] spring-cloud-dataflow-server/src/test/java/org/springframework/cloud/dataflow/integration/test/util
  • [ ] spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell
  • [ ] spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell/config
  • [ ] spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell/command
  • [ ] spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell/command/proxy
  • [ ] spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell/command/support
  • [ ] spring-cloud-dataflow-test/src/test/java/org/springframework/cloud/dataflow/core/dsl/tck
  • [ ] spring-cloud-starter-dataflow-server/src/test/java/org/springframework/cloud/dataflow/server/single/nodataflowapp
  • [ ] spring-cloud-starter-dataflow-server/src/test/java/org/springframework/cloud/dataflow/server/single/dataflowapp
  • [ ] spring-cloud-starter-dataflow-server/src/test/java/org/springframework/cloud/dataflow/server/single/security
  • [ ] spring-cloud-starter-dataflow-server/src/test/java/org/springframework/cloud/dataflow/server/single/security/support
  • [ ] spring-cloud-starter-dataflow-server/src/test/java/org/springframework/cloud/dataflow/server/single/security/support/oauth2testserver
  • [ ] spring-cloud-starter-dataflow-server/src/test/java/org/springframework/cloud/dataflow/server/local/security

jvalkeal avatar Mar 15 '21 10:03 jvalkeal

Hey there, I have read some issues and discussions, you guys are planning to migrate Junit4 to Junit5, Can outsiders work on this issue? I want to help in migrating Junit4 to Junit5. Can I get some issues to work on? Thanks :)

Devamparikh avatar Apr 12 '22 05:04 Devamparikh

Hi @Devamparikh ,

Yes, you can work on this. There is a PR to do this but it was done back in July 2021 so I am not sure how up-to-date it is. I would start by scanning that and seeing if we can use it w/ minor modifications (if needed).

Here are some tips/points that may help you:

  • try to keep the changes as small as possible becausea the fewer unrelated changers, the less painful it will be to review, the easier it will be to get merged
    • avoid formatting changes
    • try to not restructure all of the tests to use new features in Junit5 but rather get the dependencies and code references switched to Junit5. If you run into an area where you say "Oh my, this would be so clean w/ the new ABC feature in Junit5" then notate that and we can create a follow on ticket(s) to handle these improvements.
  • remove any legacy junit dependencies where we are importing them manually (because Boot no longer brings them in we had to manually import them for the modules that we still use junit4)
  • remove any exclusions of junit lib (because Boot no longer brings them in we no longer need to exclude them in modules where we were using Junit5 only)

Ping me if you have any questions.

Thanks

onobc avatar Apr 12 '22 15:04 onobc

Sure, let me first review where I can fit and I'll let you know. :)

Devamparikh avatar Apr 14 '22 14:04 Devamparikh

Hi @onobc and all, sorry to bother you, I'm curious to learn more about JUnit4 to JUnit5 migration. I have read and consulted official documents, since you are currently working on them at the moment, I would like you to give me a few tips for eg. "How you intended to migrate junit4 to junit5?" and "What challenges did you face and how did you overcome them?" Thanks in advance :)

Devamparikh avatar Apr 16 '22 17:04 Devamparikh

Hi @Devamparikh , I have migrated other applications from Junit4->Junit5 and it is pretty straightforward. There are many resources out there that give all the details (eg Baeldung).

For this work, I would first see what the current PR is lacking and update it accordingly. Then be sure to read through my comment above.

Good luck - let me know if you have any specific questions I can answer. Thanks.

onobc avatar Apr 16 '22 22:04 onobc