spring-cloud-aws
spring-cloud-aws copied to clipboard
spring-attic
Feature/AppConfig as PropertySource
Enable to use of AppConfig as PropertySource supporting Yaml & Json content-types.
@jarpz Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
I also think it should be a great idea if the support for import configuration via spring.config.import can be added. Read this post, section Support Additional Configuration. But can be part of another PR once this is done
@jarpz thanks for your contribution! this capability within AWS Systems Manager sounds interesting. I have left some comments. Also, I think this can be merged in 2.3.x branch. Do you mind to move those changes to that one?
Hi @eddumelendez, no problem, I will apply your recommendations and resubmit the PR.
Regards.
just in case there is no need to create another PR. Make sure your new local branch is base on 2.3.x and before to push --force change the base brach in this PR to 2.3.x too
I also think it should be a great idea if the support for import configuration via spring.config.import can be added. Read this post, section
Support Additional Configuration. But can be part of another PR once this is done
An interesting feature, you means (additional locations), I've already read this post. But I got some doubts.
How would be the expression?
aws-appconfig://{accountId}@{application}/{environment}... something like that?
Even I will need some research or example to understand how it works. But let me finish the PR and will go with this feature.
Regards.
about that one. let's do it after the integration of this one.
Thank you
just in case there is no need to create another PR. Make sure your new local branch is base on 2.3.x and before to
push --forcechange the base brach in this PR to 2.3.x too
add few comments in order to improve the code. Also,
spring.cloud.aws.appconfig.enabledshould be added inspring-cloud-aws-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json. You can take a look into #682
Hi @eddumelendez , I applied last comments you made. Have you seen them?
@jarpz sorry for the delay and thanks for your patience. The code looks good to me but unfortunately we are still figuring out few things. there are also some prs in progress for new modules related to parameter store and secrets manager and since this is a new one we want to make it right.
The issue is this
@jarpz sorry for the delay and thanks for your patience. The code looks good to me but unfortunately we are still figuring out few things. there are also some prs in progress for new modules related to parameter store and secrets manager and since this is a new one we want to make it right.
The issue is this
I understand. It's ok.
Anything else can I help with?
Regards
I would like to see this one for 2.3 since it has many sources such as s3, ssm document, ssm parameter. The only missing part is adding the support for the new Config Data API with prefix aws-appconfig: from spring-boot 2.4 which is already in progress for Parameter Store #723 and Secrets Manager #721. I can work on this the next days because @jarpz has already done many things already fixing all the comments submitted previously. We can add the module as an experimental module. @maciejwalkowiak wdyt?
Hi, any idea on when this will get released? Have been waiting for something like this for a while!
Hi, this will get released? Have been waiting for something like this for a while!
