spring-cloud-aws icon indicating copy to clipboard operation
spring-cloud-aws copied to clipboard

Micrometer MeterRegistryCustomizer for AWS Instance Metadata

Open darylrobbins opened this issue 7 years ago • 4 comments

It would be quite helpful if the spring-cloud-aws could provide a MeterRegistryCustomizer to automatically annotate micrometer metrics with dimensions based on the metadata from AWS (i.e Instance Type, Instance ID, AMI, region, az, tags, etc..). This would make it a lot more seamless to work with micrometer metrics in an AWS environment.

darylrobbins avatar Oct 31 '18 17:10 darylrobbins

@darylrobbins good idea. @marcingrzejszczak could I take this one?

renanreismartins avatar Jun 02 '20 07:06 renanreismartins

@renanreismartins go for it!

maciejwalkowiak avatar Jun 02 '20 08:06 maciejwalkowiak

Hi @darylrobbins, ec2 provides many metadata informations. Should we make it customisable through properties? Something like: cloud.aws.ec2.metrics.metadata=hostname,instance-id

Any suggestions of how to handle hierarchical metadata like network/interfaces/macs? Or should we start with only the flat values?

@maciejwalkowiak what would be the best place to put the MeterRegistryCustomizer?

renanreismartins avatar Jun 04 '20 12:06 renanreismartins

This would have to go to autoconfigure module I believe.

maciejwalkowiak avatar Jun 04 '20 14:06 maciejwalkowiak