github-java-client
github-java-client copied to clipboard
BUG SearchIssue id can be bigger than Integer.MAX
Represent it as Long instead of Integer.
For schema (where id is specified as 'int64') see:
https://docs.github.com/en/rest/search/search?apiVersion=2022-11-28#search-issues-and-pull-requests
Ran into this in the wild.
Hmm, build is failing with Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 65 -- not sure if this is related to my change-set?
It seems that a lot of PR-s now have ID-s that are bigger than Integer.MAX, quite easy to run into this in wild now.
Comment ID could have the same integer overflow. e.g. https://api.github.com/repos/Azure/azure-sdk-for-java/issues/comments/2188169837
It maybe safer to convert all ID of int type to long type.
Also ran into this.