ffwd-ruby icon indicating copy to clipboard operation
ffwd-ruby copied to clipboard

FastForward should support booleans

Open ghost opened this issue 11 years ago • 4 comments

If I pass FastForward a JSON boolean it fails and drops random messages.

It would be better if it could just handle the boolean and forward it.

ghost avatar Aug 25 '14 14:08 ghost

@thiderman This is what caused the heartbeat alerts on the machine when we enabled the ingestion of metrics a week ago.

xeago avatar Aug 28 '14 09:08 xeago

@wallesspotify The monitoring pipeline doesn't really support booleans, so this is bigger than a change in ffwd. What's blocking you from converting booleans to doubles before sending them to ffwd?

parmus avatar Sep 01 '14 15:09 parmus

@parmus ffwd should sanitize it's input. Currently it Kernel#dup's every value, this can't be done for TrueClass/FalseClass. If you accept json as input, you should not accept a subset of json as input, but json.

xeago avatar Sep 01 '14 15:09 xeago

Adding this as an enhancement, it's a low hanging fruit if someone wants to pick it up.

udoprog avatar Oct 19 '14 17:10 udoprog