security_content icon indicating copy to clipboard operation
security_content copied to clipboard

Adding newline after all arguments, not after evry single argument in macros

Open DipsyTipsy opened this issue 2 years ago • 1 comments

Details

Noticed that if you added more arguments to a macro, splunk would complain about the arguments being spread over several lines. Suggesting fix by having the arguments on the same line, with a newline after all the arguments.

Checklist

  • [ ] Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • [ ] CI/CD jobs passed ✔️
  • [ ] Validated SPL logic.
  • [ ] Validated tags, description, and how to implement.
  • [ ] Verified references match analytic.

DipsyTipsy avatar Nov 01 '23 15:11 DipsyTipsy

Neat PR, thanks for fixing this. We have moved our tooling that generates such file to this new repository. This new tooling is more robust and has more features to control how your yamls behave. Can you perhaps create a PR in this repository, i believe this is the file where you'd want to : https://github.com/splunk/contentctl/blob/main/contentctl/output/templates/macros.j2

Thanks again!

patel-bhavin avatar Nov 10 '23 22:11 patel-bhavin

This should now have been fixed in contentctl : Thanks @DipsyTipsy

https://github.com/splunk/contentctl/pull/78

patel-bhavin avatar Jul 10 '24 17:07 patel-bhavin