qbec icon indicating copy to clipboard operation
qbec copied to clipboard

Add support for --api-versions flag for helm template

Open kvaps opened this issue 4 years ago • 3 comments

This PR adds support for passing --api-versions to helm template command. Many charts containing lookup functions, which allow to check if Kubernetes cluster supports specific apiVersions https://helm.sh/docs/chart_template_guide/functions_and_pipelines/#using-the-lookup-function

kvaps avatar Sep 17 '21 14:09 kvaps

Codecov Report

Merging #257 (c6695dc) into master (5508c45) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   73.87%   73.88%   +0.01%     
==========================================
  Files          72       72              
  Lines        5015     5017       +2     
==========================================
+ Hits         3705     3707       +2     
  Misses       1101     1101              
  Partials      209      209              
Impacted Files Coverage Δ
vm/internal/natives/helm.go 90.24% <100.00%> (+0.50%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5508c45...c6695dc. Read the comment docs.

codecov-commenter avatar Sep 17 '21 14:09 codecov-commenter

@kvaps qbec know supports external datasources https://qbec.io/reference/jsonnet-external-data/. It is possible to use helm(or any other tool) in a generic way without requiring native functions. @gotwarlost maybe we should looking at dropping the expandHelmTemplate in a future release

harsimranmaan avatar Sep 20 '21 19:09 harsimranmaan

@harsimranmaan since https://github.com/splunk/qbec/issues/286 function expandHelmTemplate might be considered as a stable one. Could you please merge this change?

Andor avatar Nov 27 '23 15:11 Andor