php-client icon indicating copy to clipboard operation
php-client copied to clipboard

[WIP] Allowing Multiple Factory Instantiation

Open mmelograno opened this issue 3 years ago • 3 comments

PHP SDK

What did you accomplish?

  • Removed cache from Di.
  • Attached cache into ImpressionCache, EventsCache, SplitCache and SegmentCache.
  • Send storages to Client and Manager.
  • Added context for Evaluator to be used in SegmentMatcher.
  • Remove Splitter from Di and made it static.
  • Updated MultipleFactoryInstantiation logic to allow it.
  • Di component was replaced in favor of Context

How do we test the changes introduced in this PR?

Extra Notes

mmelograno avatar Nov 17 '22 16:11 mmelograno

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube