dokuwiki-plugin-dw2pdf
dokuwiki-plugin-dw2pdf copied to clipboard
Proxy support based on DW's main configuration
Hello,
Here is a small patch that solves issue #245 by setting mPDF's curlProxy and curlProxyAuth configuration variables based on Dokuwiki's proxy configuration (if it is set).
Kind regards,
E.B.
Thanks! Looks logic for me, @splitbrain could you have a look as well?
Well, in principle this makes sense.
However, preferably dw2pdf would use DokuWiki's own HTTP client instead of relying on curl. That should be possible by implementing our own \Mpdf\Http\ClientInterface
See https://mpdf.github.io/configuration/configuration-v7-x.html#http-client
In this case, please feel free to reject this pull request as I don't have enough time to dig into this at the moment.