sphinx icon indicating copy to clipboard operation
sphinx copied to clipboard

Published 20 hours ago • verified publisher icon sphinx-doc

Fix/agogo

Open gvimont opened this issue 3 years ago • 3 comments

Subject:

Feature or Bugfix

  • Bugfix

Purpose

This improves the display of the sidebar of the agogo theme

Relates

#10715

gvimont avatar Jul 27 '22 14:07 gvimont

@mgeier Could you check this please?

tk0miya avatar Jul 28 '22 00:07 tk0miya

This doesn't fully restore the CSS from before https://github.com/sphinx-doc/sphinx/pull/10520/files (e.g. the rightsidebar option is ignored).

I don't think the pagewidth = 100% change is good, because it removes the left/right margin of the page and the text touches the edge of the window.

The sidebar directive is still not properly styled, but I guess no agogo user uses that.

I'm not sure it's worth trying to fix agogo. Maybe it's best to revert #10520 and accept that it is broken?

Just out of curiosity: @gvimont Do you actually use the agogo theme? Or how did you notice the problem?

mgeier avatar Aug 04 '22 19:08 mgeier

Yes, I'm actually using it (but I could probably use another theme). I could change pagewidth to a better value. As you said, another solution is to revert #10520, and the theme could be marked as deprecated if it is not maintained anymore.

gvimont avatar Aug 08 '22 12:08 gvimont

I've created an alternative PR which reverts my previous change: #10787

mgeier avatar Aug 26 '22 18:08 mgeier

I'll accept the revert commit.

A

AA-Turner avatar Aug 28 '22 19:08 AA-Turner