sphinx
sphinx copied to clipboard
fix a few 'flake8-simplify' lints
please just blacklist deprecated modules from the lint rather than changing them (e.g. jsdump).
A
Oh actually, this PR should also add flake8-simplify to the plugin list, right?
A
Oh actually, this PR should also add
flake8-simplifyto the plugin list, right?A
that's my intention. right now it's still generating a lot of errors
that's my intention. right now it's still generating a lot of errors
OK. Do you want this PR merged, or do you want to hold off? (It is still marked as 'draft', with no indication as to why.)
A
that's my intention. right now it's still generating a lot of errors
OK. Do you want this PR merged, or do you want to hold off? (It is still marked as 'draft', with no indication as to why.)
A
It's marked as a draft because I'm (ab)using the CI to validate the changes I make incrementally. When it's ready for review I'll remove the "draft" status
How about merging this after CI passed? It's better to merge step by step even if your work still remained. Large and long life PR is difficult to review, merge and keep maintained (from conflicts).
i think i'm going to have to close this. I can address these lints in separate PRs