sphinx icon indicating copy to clipboard operation
sphinx copied to clipboard

fix a few 'flake8-simplify' lints

Open danieleades opened this issue 3 years ago • 6 comments

danieleades avatar Jul 01 '22 17:07 danieleades

please just blacklist deprecated modules from the lint rather than changing them (e.g. jsdump).

A

AA-Turner avatar Jul 01 '22 20:07 AA-Turner

Oh actually, this PR should also add flake8-simplify to the plugin list, right?

A

AA-Turner avatar Jul 02 '22 10:07 AA-Turner

Oh actually, this PR should also add flake8-simplify to the plugin list, right?

A

that's my intention. right now it's still generating a lot of errors

danieleades avatar Jul 02 '22 16:07 danieleades

that's my intention. right now it's still generating a lot of errors

OK. Do you want this PR merged, or do you want to hold off? (It is still marked as 'draft', with no indication as to why.)

A

AA-Turner avatar Jul 03 '22 11:07 AA-Turner

that's my intention. right now it's still generating a lot of errors

OK. Do you want this PR merged, or do you want to hold off? (It is still marked as 'draft', with no indication as to why.)

A

It's marked as a draft because I'm (ab)using the CI to validate the changes I make incrementally. When it's ready for review I'll remove the "draft" status

danieleades avatar Jul 03 '22 11:07 danieleades

How about merging this after CI passed? It's better to merge step by step even if your work still remained. Large and long life PR is difficult to review, merge and keep maintained (from conflicts).

tk0miya avatar Jul 18 '22 06:07 tk0miya

i think i'm going to have to close this. I can address these lints in separate PRs

danieleades avatar Dec 30 '22 12:12 danieleades