sphero.js icon indicating copy to clipboard operation
sphero.js copied to clipboard

Fixes connection error handling

Open jamuus opened this issue 10 years ago • 5 comments
trafficstars

Before, when initialising serial port, it was defaulting to open immediately, which was using its own callback that emitted an error when there was one. serialport.js looks like it was trying to give a callback of its own but the open event never passes a value.

I have set serialport to not open immediately, and corrected the open line such that an error will be passed to the callback. Then I added error handling to the sphero connect function such that an error is passed to whatever calls connect.

This now means that connect's callback isn't only called on a successful connection. This could be avoided by properly catching and emitting the error events such that a orb.on('error'... will catch them.

jamuus avatar Oct 20 '15 00:10 jamuus

You are correct, the port should not be open instantly, but wait for sphero.js to open it. Could you pls fix the tests failing so we can merge this?

edgarsilva avatar Oct 20 '15 00:10 edgarsilva

I'll fix the tests and cleanup these commits when I get a chance to learn how Mocha works.

jamuus avatar Oct 23 '15 12:10 jamuus

Have fixed the linting but don't know what I'm doing with tests aha

zoetrope69 avatar Jan 03 '16 00:01 zoetrope69

I've removed the irrelevant commits.

jamuus avatar Feb 06 '16 11:02 jamuus

Thanks @jamuus I think it just needs the change I mentioned here https://github.com/orbotix/sphero.js/pull/57#discussion_r52104117

deadprogram avatar Feb 06 '16 16:02 deadprogram