spectral icon indicating copy to clipboard operation
spectral copied to clipboard

as per request

Open YannChemin opened this issue 2 years ago • 1 comments

Loads basic info, does not load type, class and subclass some code using ignorefiles is not needed

YannChemin avatar Oct 17 '23 07:10 YannChemin

@tboggs, I have extensively tested it, and it works very well. Can we merge it in the master?

LaurentBerder avatar Jun 10 '24 09:06 LaurentBerder

Hi @tboggs, any update on this side?

YannChemin avatar Jul 30 '24 12:07 YannChemin

Hi @YannChemin, apologies for the delay. I'm away from my dev system for a few days. I'll review & test this by next week.

tboggs avatar Jul 31 '24 15:07 tboggs

The code looks good to me but before merging to master, please add some basic unit tests for creating and querying a Relab database. You should be able to copy most of the test code from one of the other databases in this file (you can also add the unit tests to the same file).

tboggs avatar Aug 05 '24 20:08 tboggs

This is done, test added

YannChemin avatar Aug 06 '24 09:08 YannChemin

@tboggs

YannChemin avatar Aug 06 '24 09:08 YannChemin

@YannChemin Thanks for adding the unit tests. I will have time to test the code in the next day or two and merge into master.

In the meantime, could you please rename the relabDatabase class to RelabDatabase to maintain pep8 compliance for class names?

tboggs avatar Aug 07 '24 16:08 tboggs

OK done @tboggs

YannChemin avatar Aug 08 '24 08:08 YannChemin

@YannChemin, I'm ready to look at this now. Are PR #158 and #160 identical, just merging to different branches?

tboggs avatar Aug 09 '24 18:08 tboggs